Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move inline scripts and styles into separate files #2647

Closed
swissspidy opened this issue Jun 17, 2019 · 2 comments
Closed

Move inline scripts and styles into separate files #2647

swissspidy opened this issue Jun 17, 2019 · 2 comments
Labels
Enhancement New feature or improvement of an existing one P2 Low priority

Comments

@swissspidy
Copy link
Collaborator

There are a few instances on the AMP plugin's admin pages where some necessary JS and CSS for these screens is printed inline.

In order to make these easier to maintain together with the rest of our JS and CSS, I'd suggest extracting these into their own separate files.

This is a bit of a lower priority thing, because in the future there might be some bigger UI changes anyway. Wanted to track this nonetheless :-)

@swissspidy swissspidy added Enhancement New feature or improvement of an existing one P2 Low priority labels Jun 17, 2019
@westonruter
Copy link
Member

Yes, we'll need to do this as part of the redesign of the screens in #2316.

@westonruter
Copy link
Member

Closing as this will be a given with #2316.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement of an existing one P2 Low priority
Projects
None yet
Development

No branches or pull requests

2 participants