Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when a site is not served via HTTPS #2006

Closed
westonruter opened this issue Mar 21, 2019 · 3 comments · Fixed by #3219
Closed

Add warning when a site is not served via HTTPS #2006

westonruter opened this issue Mar 21, 2019 · 3 comments · Fixed by #3219
Assignees
Labels
Enhancement New feature or improvement of an existing one
Milestone

Comments

@westonruter
Copy link
Member

Many AMP components require HTTPS to function. When a page is not served as HTTPS, an AMP component can just fail to work (e.g. forms) leaving the user in confusion. See Automattic/jetpack#11595. While we originally thought in #969 to just handle the warning in the PWA plugin, since it is so important to serve as HTTPS we should show a warning on the AMP settings screen similar to how we show a warning when not using an object caching plugin.

This would be unnecessary if core starts to show a non-HTTPS warning as part of Health Check before we get around to it.

@westonruter westonruter added this to the v1.2 milestone Mar 21, 2019
@westonruter
Copy link
Member Author

Another key reason why this is needed is images just start throwing validation errors for no apparent reason. The reason is the HTTP protocol is not allowed, at least for the noscript > img inside of the amp-img.

@westonruter
Copy link
Member Author

Note that Site Health in core now has this:

image

@westonruter westonruter modified the milestones: v1.2, v1.3 Jun 7, 2019
@swissspidy swissspidy added the Enhancement New feature or improvement of an existing one label Jun 9, 2019
This was referenced Jul 15, 2019
@westonruter westonruter removed this from the v1.3 milestone Sep 3, 2019
@MackenzieHartung MackenzieHartung added this to the v1.3 milestone Sep 5, 2019
@westonruter
Copy link
Member Author

Add a warning on the AMP settings screen when not on HTTPS, similar to the object caching warning.

In addition, both HTTPS and object caching should be added as Site Health entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement of an existing one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants