Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface AMP mode types to improve Error Validation workflow #1353

Closed
postphotos opened this issue Aug 23, 2018 · 3 comments
Closed

Surface AMP mode types to improve Error Validation workflow #1353

postphotos opened this issue Aug 23, 2018 · 3 comments
Milestone

Comments

@postphotos
Copy link
Contributor

As a user, I should know which mode I'm on in the error listings and whether actions I take will affect the pages on my slte.

Considered as a sub-task to #1006.

Formal ACs to come.

cc: @jwold

@jwold
Copy link
Collaborator

jwold commented Aug 23, 2018

notice flow

@westonruter
Copy link
Member

This is implemented, no?

In paired mode with auto-sanitization I see:

image

In paired mode without auto-sanitization I see:

image

In native mode I see:

image

@westonruter westonruter added this to the v1.0 milestone Dec 5, 2018
@kienstra
Copy link
Contributor

kienstra commented Dec 5, 2018

Good point, @westonruter. #1676 implements this. Thanks for moving this into the v1.0 milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants