From 636a843ec2104c48e9f1a730e868c37294d0fb69 Mon Sep 17 00:00:00 2001 From: Weston Ruter Date: Wed, 20 Feb 2019 12:16:53 -0800 Subject: [PATCH] Update contributing instructions for current amphtml-update process --- contributing.md | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/contributing.md b/contributing.md index bc84baf686e..4bf851d7192 100644 --- a/contributing.md +++ b/contributing.md @@ -90,10 +90,18 @@ This will create an `amp.zip` in the plugin directory which you can install. The ## Updating Allowed Tags And Attributes The file `class-amp-allowed-tags-generated.php` has the AMP specification's allowed tags and attributes. It's used in sanitization. -To update that file: + +To update that file, perform the following steps (which need to be improved): + 1. `cd` to the root of this plugin -2. run `bash bin/amphtml-update.sh` -That script is intended for a Linux environment like [VVV](https://github.com/Varying-Vagrant-Vagrants/VVV). +2. Find the most recent stable release of AMP at https://github.com/ampproject/amphtml/releases (e.g. 1902081532110) +3. Update `composer.json` replacing the old tag references for `ampproject/amphtml` to the latest version. +4. Run `rm composer.lock && composer install`. +5. Run `bash bin/amphtml-update.sh` (or `lando ssh -c 'bash bin/amphtml-update.sh'` if using Lando) +6. Update tests based on changes to the spec. +7. Commit changes. + +This script is intended for a Linux environment like [VVV](https://github.com/Varying-Vagrant-Vagrants/VVV) or [Lando wordpressdev](https://github.com/felixarntz/wordpressdev). ## Testing Media And Embed Support