From 93bef8486269c9acae1489335633d858eedc7350 Mon Sep 17 00:00:00 2001 From: Ryan Kienstra Date: Tue, 3 Apr 2018 12:50:15 -0500 Subject: [PATCH 01/18] Update 'Changelog' of readme files. Add new items since the first Beta release. And elaborate more on 'Native AMP' and 'Paired Mode.' --- readme.md | 7 ++++++- readme.txt | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/readme.md b/readme.md index f5693b78884..975e0fa32b9 100644 --- a/readme.md +++ b/readme.md @@ -57,14 +57,19 @@ Follow along with or [contribute](https://github.com/Automattic/amp-wp/blob/deve ## Changelog ## ### 0.7 (unreleased) ### -- Add support for canonical AMP, if the theme registers support for it with `add_theme_support( 'amp' )`. See [#857](https://github.com/Automattic/amp-wp/pull/857), [#856](https://github.com/Automattic/amp-wp/pull/856). Props westonruter, kaitnyl, ThierryA. +- Render an entire site as "Native AMP" if the theme calls `add_theme_support( 'amp' )`. See [#857](https://github.com/Automattic/amp-wp/pull/857). Props westonruter, kaitnyl, ThierryA. +- Use "Paired Mode" if the theme calls `add_theme_support( 'amp' )` and passes a `'template_dir'` value for the AMP templates. See [#856](https://github.com/Automattic/amp-wp/pull/856). Props westonruter, kaitnyl. - Add support for all default WordPress widgets. See [#921](https://github.com/Automattic/amp-wp/pull/921), [#917](https://github.com/Automattic/amp-wp/pull/917). Props kienstra, westonruter. - Add support for more default embeds: Issuu, Post, Meetup, Reddit, Screencast, Tumblr, and WordPress Plugin Directory. See [#889](https://github.com/Automattic/amp-wp/pull/889). Props kaitnyl. - Allow native WordPress commenting, in fully valid AMP. See [#871](https://github.com/Automattic/amp-wp/pull/871), [#909](https://github.com/Automattic/amp-wp/pull/909). Props DavidCramer, westonruter. +- Optionally use `` to display comments, avoiding full-page refreshes on adding comments. See [#1029](https://github.com/Automattic/amp-wp/pull/1029). Props DavidCramer, westonruter. +- Add a complete UI for validation errors, including invalid tags and attributes. See [#971](https://github.com/Automattic/amp-wp/pull/971). Props westonruter, kienstra. +- On activating a plugin, validate a front-end page and display a notice if there were errors. See [#971](https://github.com/Automattic/amp-wp/pull/971). Props westonruter, kienstra. - Creation of AMP-related notifications, on entering invalid content in the 'classic' editor. See [#912](https://github.com/Automattic/amp-wp/pull/912/). Props kienstra, westonruter, ThierryA. - Add output buffering, ensuring the entire page is valid AMP. See [#929](https://github.com/Automattic/amp-wp/pull/929), [#857](https://github.com/Automattic/amp-wp/pull/857). Props westonruter, ThierryA. - Update the generated sanitizer file to the AMP spec, and simplify the file that generates it. See [#929](https://github.com/Automattic/amp-wp/pull/929). Props westonruter. - Add validation of host names in URLs. See [#983](https://github.com/Automattic/amp-wp/pull/983). Props rubengonzalezmrf. +- Add wp-cli scripts to test AMP support of comments and widgets. See [#924](https://github.com/Automattic/amp-wp/pull/924), [#859](https://github.com/Automattic/amp-wp/pull/859). Props DavidCramer, kienstra. See [0.7 milestone](https://github.com/Automattic/amp-wp/milestone/6?closed=1). diff --git a/readme.txt b/readme.txt index 21a2be07b52..a948ed5bd21 100644 --- a/readme.txt +++ b/readme.txt @@ -40,14 +40,19 @@ Follow along with or [contribute](https://github.com/Automattic/amp-wp/blob/deve = 0.7 (unreleased) = -- Add support for canonical AMP, if the theme registers support for it with `add_theme_support( 'amp' )`. See [#857](https://github.com/Automattic/amp-wp/pull/857), [#856](https://github.com/Automattic/amp-wp/pull/856). Props westonruter, kaitnyl, ThierryA. +- Render an entire site as "Native AMP" if the theme calls `add_theme_support( 'amp' )`. See [#857](https://github.com/Automattic/amp-wp/pull/857). Props westonruter, kaitnyl, ThierryA. +- Use "Paired Mode" if the theme calls `add_theme_support( 'amp' )` and passes a `'template_dir'` value for the AMP templates. See [#856](https://github.com/Automattic/amp-wp/pull/856). Props westonruter, kaitnyl. - Add support for all default WordPress widgets. See [#921](https://github.com/Automattic/amp-wp/pull/921), [#917](https://github.com/Automattic/amp-wp/pull/917). Props kienstra, westonruter. - Add support for more default embeds: Issuu, Post, Meetup, Reddit, Screencast, Tumblr, and WordPress Plugin Directory. See [#889](https://github.com/Automattic/amp-wp/pull/889). Props kaitnyl. - Allow native WordPress commenting, in fully valid AMP. See [#871](https://github.com/Automattic/amp-wp/pull/871), [#909](https://github.com/Automattic/amp-wp/pull/909). Props DavidCramer, westonruter. +- Optionally use `` to display comments, avoiding full-page refreshes on adding comments. See [#1029](https://github.com/Automattic/amp-wp/pull/1029). Props DavidCramer, westonruter. +- Add a complete UI for validation errors, including invalid tags and attributes. See [#971](https://github.com/Automattic/amp-wp/pull/971). Props westonruter, kienstra. +- On activating a plugin, validate a front-end page and display a notice if there were errors. See [#971](https://github.com/Automattic/amp-wp/pull/971). Props westonruter, kienstra. - Creation of AMP-related notifications, on entering invalid content in the 'classic' editor. See [#912](https://github.com/Automattic/amp-wp/pull/912/). Props kienstra, westonruter, ThierryA. - Add output buffering, ensuring the entire page is valid AMP. See [#929](https://github.com/Automattic/amp-wp/pull/929), [#857](https://github.com/Automattic/amp-wp/pull/857). Props westonruter, ThierryA. - Update the generated sanitizer file to the AMP spec, and simplify the file that generates it. See [#929](https://github.com/Automattic/amp-wp/pull/929). Props westonruter. - Add validation of host names in URLs. See [#983](https://github.com/Automattic/amp-wp/pull/983). Props rubengonzalezmrf. +- Add wp-cli scripts to test AMP support of comments and widgets. See [#924](https://github.com/Automattic/amp-wp/pull/924), [#859](https://github.com/Automattic/amp-wp/pull/859). Props DavidCramer, kienstra. See [0.7 milestone](https://github.com/Automattic/amp-wp/milestone/6?closed=1). From 296f7026cc356bb6b8f0930506b35e2543f2485a Mon Sep 17 00:00:00 2001 From: Ryan Kienstra Date: Wed, 4 Apr 2018 13:26:00 -0500 Subject: [PATCH 02/18] Update readme 'Description' for version 0.7. Mainly describe 'Native AMP' and 'Paired Mode.' Delete line from the legacy templating, which stated which pages aren't supported. --- readme.md | 8 ++++++-- readme.txt | 8 ++++++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/readme.md b/readme.md index 975e0fa32b9..359e4cde5f2 100644 --- a/readme.md +++ b/readme.md @@ -20,9 +20,13 @@ This plugin adds support for the [Accelerated Mobile Pages](https://www.ampproje With the plugin active, all posts on your site will have dynamically generated AMP-compatible versions, accessible by appending `/amp/` to the end your post URLs. For example, if your post URL is `http://example.com/2016/01/01/amp-on/`, you can access the AMP version at `http://example.com/2016/01/01/amp-on/amp/`. If you do not have [pretty permalinks](https://codex.wordpress.org/Using_Permalinks#mod_rewrite:_.22Pretty_Permalinks.22) enabled, you can do the same thing by appending `?amp=1`, i.e. `http://example.com/?p=123&=1` -Note #1: homepage, the blog index, and archives are not currently supported. +Also, your pages and custom post types can have AMP versions. Simply check their boxes on the 'AMP Settings' page in `wp-admin/`. -Note #2: this plugin only creates AMP content but does not automatically display it to your users when they visit from a mobile device. That is handled by AMP consumers such as Google Search. For more details, see the [AMP Project FAQ](https://www.ampproject.org/docs/support/faqs.html). +Your entire site can render as "Native AMP" if your theme calls `add_theme_support( 'amp' )`. There will only be one version of each URL: the AMP version. There won't be separate URLs with `/amp` or `?amp` appended. See this [wiki page](https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support#native-amp) for details and restrictions. + +Your theme can also [use Paired Mode](https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support#paired-mode), with your own custom templates for the AMP URLs. + +This plugin only creates AMP content but does not automatically display it to your users when they visit from a mobile device. That is handled by AMP consumers such as Google Search. For more details, see the [AMP Project FAQ](https://www.ampproject.org/docs/support/faqs.html). Follow along with or [contribute](https://github.com/Automattic/amp-wp/blob/develop/contributing.md) to the development of this plugin [on GitHub](https://github.com/Automattic/amp-wp). For more information on the plugin, how the plugin works and how to configure and extend it, please see the [project wiki](https://github.com/Automattic/amp-wp/wiki). diff --git a/readme.txt b/readme.txt index a948ed5bd21..1ab1a214fcc 100644 --- a/readme.txt +++ b/readme.txt @@ -16,9 +16,13 @@ This plugin adds support for the [Accelerated Mobile Pages](https://www.ampproje With the plugin active, all posts on your site will have dynamically generated AMP-compatible versions, accessible by appending `/amp/` to the end your post URLs. For example, if your post URL is `http://example.com/2016/01/01/amp-on/`, you can access the AMP version at `http://example.com/2016/01/01/amp-on/amp/`. If you do not have [pretty permalinks](https://codex.wordpress.org/Using_Permalinks#mod_rewrite:_.22Pretty_Permalinks.22) enabled, you can do the same thing by appending `?amp=1`, i.e. `http://example.com/?p=123&=1` -Note #1: homepage, the blog index, and archives are not currently supported. +Also, your pages and custom post types can have AMP versions. Simply check their boxes on the 'AMP Settings' page in `wp-admin/`. -Note #2: this plugin only creates AMP content but does not automatically display it to your users when they visit from a mobile device. That is handled by AMP consumers such as Google Search. For more details, see the [AMP Project FAQ](https://www.ampproject.org/docs/support/faqs.html). +Your entire site can render as "Native AMP" if your theme calls `add_theme_support( 'amp' )`. There will only be one version of each URL: the AMP version. There won't be separate URLs with `/amp` or `?amp` appended. See this [wiki page](https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support#native-amp) for details and restrictions. + +Your theme can also [use Paired Mode](https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support#paired-mode), with your own custom templates for the AMP URLs. + +This plugin only creates AMP content but does not automatically display it to your users when they visit from a mobile device. That is handled by AMP consumers such as Google Search. For more details, see the [AMP Project FAQ](https://www.ampproject.org/docs/support/faqs.html). Follow along with or [contribute](https://github.com/Automattic/amp-wp/blob/develop/contributing.md) to the development of this plugin [on GitHub](https://github.com/Automattic/amp-wp). For more information on the plugin, how the plugin works and how to configure and extend it, please see the [project wiki](https://github.com/Automattic/amp-wp/wiki). From feed12b7ea90697d1ec713c6673f981edab6a3ca Mon Sep 17 00:00:00 2001 From: Ryan Kienstra Date: Wed, 4 Apr 2018 20:13:20 -0500 Subject: [PATCH 03/18] Add a line to the description about native WP feature support. 0.7 adds support for several native WP features, like commenting and more widgets. --- readme.md | 4 +++- readme.txt | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/readme.md b/readme.md index 359e4cde5f2..0c45a08dd02 100644 --- a/readme.md +++ b/readme.md @@ -24,7 +24,9 @@ Also, your pages and custom post types can have AMP versions. Simply check their Your entire site can render as "Native AMP" if your theme calls `add_theme_support( 'amp' )`. There will only be one version of each URL: the AMP version. There won't be separate URLs with `/amp` or `?amp` appended. See this [wiki page](https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support#native-amp) for details and restrictions. -Your theme can also [use Paired Mode](https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support#paired-mode), with your own custom templates for the AMP URLs. +Your theme can also [use "Paired Mode"](https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support#paired-mode), with your own custom templates for the AMP URLs. + +"Native AMP" and "Paired Mode" add full support for commenting and widgets. This plugin only creates AMP content but does not automatically display it to your users when they visit from a mobile device. That is handled by AMP consumers such as Google Search. For more details, see the [AMP Project FAQ](https://www.ampproject.org/docs/support/faqs.html). diff --git a/readme.txt b/readme.txt index 1ab1a214fcc..534b6c2e8af 100644 --- a/readme.txt +++ b/readme.txt @@ -20,7 +20,9 @@ Also, your pages and custom post types can have AMP versions. Simply check their Your entire site can render as "Native AMP" if your theme calls `add_theme_support( 'amp' )`. There will only be one version of each URL: the AMP version. There won't be separate URLs with `/amp` or `?amp` appended. See this [wiki page](https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support#native-amp) for details and restrictions. -Your theme can also [use Paired Mode](https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support#paired-mode), with your own custom templates for the AMP URLs. +Your theme can also [use "Paired Mode"](https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support#paired-mode), with your own custom templates for the AMP URLs. + +"Native AMP" and "Paired Mode" add full support for commenting and widgets. This plugin only creates AMP content but does not automatically display it to your users when they visit from a mobile device. That is handled by AMP consumers such as Google Search. For more details, see the [AMP Project FAQ](https://www.ampproject.org/docs/support/faqs.html). From 3774c537961b73a5c74b26d52b39eab25acb3ae9 Mon Sep 17 00:00:00 2001 From: Ryan Kienstra Date: Wed, 4 Apr 2018 20:18:54 -0500 Subject: [PATCH 04/18] Remove quotes around "Paired Mode" inside link. Instead, of linking in 'use "Paired Mode", Simply link in 'Paired Mode'. This removes the need for quotes. --- readme.md | 2 +- readme.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/readme.md b/readme.md index 0c45a08dd02..206361fd0e7 100644 --- a/readme.md +++ b/readme.md @@ -24,7 +24,7 @@ Also, your pages and custom post types can have AMP versions. Simply check their Your entire site can render as "Native AMP" if your theme calls `add_theme_support( 'amp' )`. There will only be one version of each URL: the AMP version. There won't be separate URLs with `/amp` or `?amp` appended. See this [wiki page](https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support#native-amp) for details and restrictions. -Your theme can also [use "Paired Mode"](https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support#paired-mode), with your own custom templates for the AMP URLs. +Your theme can also use [Paired Mode](https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support#paired-mode), with your own custom templates for the AMP URLs. "Native AMP" and "Paired Mode" add full support for commenting and widgets. diff --git a/readme.txt b/readme.txt index 534b6c2e8af..46de159c5b1 100644 --- a/readme.txt +++ b/readme.txt @@ -20,7 +20,7 @@ Also, your pages and custom post types can have AMP versions. Simply check their Your entire site can render as "Native AMP" if your theme calls `add_theme_support( 'amp' )`. There will only be one version of each URL: the AMP version. There won't be separate URLs with `/amp` or `?amp` appended. See this [wiki page](https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support#native-amp) for details and restrictions. -Your theme can also [use "Paired Mode"](https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support#paired-mode), with your own custom templates for the AMP URLs. +Your theme can also use [Paired Mode](https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support#paired-mode), with your own custom templates for the AMP URLs. "Native AMP" and "Paired Mode" add full support for commenting and widgets. From 3741412b59e55252d87e070405855b0ee6229622 Mon Sep 17 00:00:00 2001 From: Ryan Kienstra Date: Wed, 4 Apr 2018 20:29:04 -0500 Subject: [PATCH 05/18] Remove 'dynamically generated,' move slash. This phrase probably isn't needed. Also, move the slash to the beginning of wp-admin --- readme.md | 4 ++-- readme.txt | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/readme.md b/readme.md index 206361fd0e7..938dc45eb5f 100644 --- a/readme.md +++ b/readme.md @@ -18,9 +18,9 @@ Enable Accelerated Mobile Pages (AMP) on your WordPress site. This plugin adds support for the [Accelerated Mobile Pages](https://www.ampproject.org) (AMP) Project, which is an open source initiative that aims to provide mobile optimized content that can load instantly everywhere. -With the plugin active, all posts on your site will have dynamically generated AMP-compatible versions, accessible by appending `/amp/` to the end your post URLs. For example, if your post URL is `http://example.com/2016/01/01/amp-on/`, you can access the AMP version at `http://example.com/2016/01/01/amp-on/amp/`. If you do not have [pretty permalinks](https://codex.wordpress.org/Using_Permalinks#mod_rewrite:_.22Pretty_Permalinks.22) enabled, you can do the same thing by appending `?amp=1`, i.e. `http://example.com/?p=123&=1` +With the plugin active, all posts on your site will have AMP-compatible versions, accessible by appending `/amp/` to the end your post URLs. For example, if your post URL is `http://example.com/2016/01/01/amp-on/`, you can access the AMP version at `http://example.com/2016/01/01/amp-on/amp/`. If you do not have [pretty permalinks](https://codex.wordpress.org/Using_Permalinks#mod_rewrite:_.22Pretty_Permalinks.22) enabled, you can do the same thing by appending `?amp=1`, i.e. `http://example.com/?p=123&=1` -Also, your pages and custom post types can have AMP versions. Simply check their boxes on the 'AMP Settings' page in `wp-admin/`. +Also, your pages and custom post types can have AMP versions. Simply check their boxes on the 'AMP Settings' page in `/wp-admin`. Your entire site can render as "Native AMP" if your theme calls `add_theme_support( 'amp' )`. There will only be one version of each URL: the AMP version. There won't be separate URLs with `/amp` or `?amp` appended. See this [wiki page](https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support#native-amp) for details and restrictions. diff --git a/readme.txt b/readme.txt index 46de159c5b1..0496f645904 100644 --- a/readme.txt +++ b/readme.txt @@ -14,9 +14,9 @@ Enable Accelerated Mobile Pages (AMP) on your WordPress site. This plugin adds support for the [Accelerated Mobile Pages](https://www.ampproject.org) (AMP) Project, which is an open source initiative that aims to provide mobile optimized content that can load instantly everywhere. -With the plugin active, all posts on your site will have dynamically generated AMP-compatible versions, accessible by appending `/amp/` to the end your post URLs. For example, if your post URL is `http://example.com/2016/01/01/amp-on/`, you can access the AMP version at `http://example.com/2016/01/01/amp-on/amp/`. If you do not have [pretty permalinks](https://codex.wordpress.org/Using_Permalinks#mod_rewrite:_.22Pretty_Permalinks.22) enabled, you can do the same thing by appending `?amp=1`, i.e. `http://example.com/?p=123&=1` +With the plugin active, all posts on your site will have AMP-compatible versions, accessible by appending `/amp/` to the end your post URLs. For example, if your post URL is `http://example.com/2016/01/01/amp-on/`, you can access the AMP version at `http://example.com/2016/01/01/amp-on/amp/`. If you do not have [pretty permalinks](https://codex.wordpress.org/Using_Permalinks#mod_rewrite:_.22Pretty_Permalinks.22) enabled, you can do the same thing by appending `?amp=1`, i.e. `http://example.com/?p=123&=1` -Also, your pages and custom post types can have AMP versions. Simply check their boxes on the 'AMP Settings' page in `wp-admin/`. +Also, your pages and custom post types can have AMP versions. Simply check their boxes on the 'AMP Settings' page in `/wp-admin`. Your entire site can render as "Native AMP" if your theme calls `add_theme_support( 'amp' )`. There will only be one version of each URL: the AMP version. There won't be separate URLs with `/amp` or `?amp` appended. See this [wiki page](https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support#native-amp) for details and restrictions. From 1b7cdc657a0cd7d0f3342bfac06305ecb16dafd9 Mon Sep 17 00:00:00 2001 From: Ryan Kienstra Date: Thu, 5 Apr 2018 13:46:54 -0500 Subject: [PATCH 06/18] Change the first line in the description. Make this shorter, and focus on the benifits of AMP. --- readme.md | 2 +- readme.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/readme.md b/readme.md index 938dc45eb5f..4ed03622b7a 100644 --- a/readme.md +++ b/readme.md @@ -16,7 +16,7 @@ Enable Accelerated Mobile Pages (AMP) on your WordPress site. ## Description ## -This plugin adds support for the [Accelerated Mobile Pages](https://www.ampproject.org) (AMP) Project, which is an open source initiative that aims to provide mobile optimized content that can load instantly everywhere. +AMP, the WordPress way. Bring the speed and features of the open source [AMP project](https://www.ampproject.org/) to your site. With the plugin active, all posts on your site will have AMP-compatible versions, accessible by appending `/amp/` to the end your post URLs. For example, if your post URL is `http://example.com/2016/01/01/amp-on/`, you can access the AMP version at `http://example.com/2016/01/01/amp-on/amp/`. If you do not have [pretty permalinks](https://codex.wordpress.org/Using_Permalinks#mod_rewrite:_.22Pretty_Permalinks.22) enabled, you can do the same thing by appending `?amp=1`, i.e. `http://example.com/?p=123&=1` diff --git a/readme.txt b/readme.txt index 0496f645904..2ec3e22580a 100644 --- a/readme.txt +++ b/readme.txt @@ -12,7 +12,7 @@ Enable Accelerated Mobile Pages (AMP) on your WordPress site. == Description == -This plugin adds support for the [Accelerated Mobile Pages](https://www.ampproject.org) (AMP) Project, which is an open source initiative that aims to provide mobile optimized content that can load instantly everywhere. +AMP, the WordPress way. Bring the speed and features of the open source [AMP project](https://www.ampproject.org/) to your site. With the plugin active, all posts on your site will have AMP-compatible versions, accessible by appending `/amp/` to the end your post URLs. For example, if your post URL is `http://example.com/2016/01/01/amp-on/`, you can access the AMP version at `http://example.com/2016/01/01/amp-on/amp/`. If you do not have [pretty permalinks](https://codex.wordpress.org/Using_Permalinks#mod_rewrite:_.22Pretty_Permalinks.22) enabled, you can do the same thing by appending `?amp=1`, i.e. `http://example.com/?p=123&=1` From 03cd565e213fefd1c66cf506df64222243a37f1d Mon Sep 17 00:00:00 2001 From: Ryan Kienstra Date: Thu, 5 Apr 2018 13:59:39 -0500 Subject: [PATCH 07/18] Update the description, using Alberto's suggestion. This now leads with the benefits. And ends with 'the WordPress way.' --- readme.md | 2 +- readme.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/readme.md b/readme.md index 4ed03622b7a..e3aefa7c4ff 100644 --- a/readme.md +++ b/readme.md @@ -16,7 +16,7 @@ Enable Accelerated Mobile Pages (AMP) on your WordPress site. ## Description ## -AMP, the WordPress way. Bring the speed and features of the open source [AMP project](https://www.ampproject.org/) to your site. +Bring the speed and features of the open source [AMP project](https://www.ampproject.org/) to your site, the WordPress way. With the plugin active, all posts on your site will have AMP-compatible versions, accessible by appending `/amp/` to the end your post URLs. For example, if your post URL is `http://example.com/2016/01/01/amp-on/`, you can access the AMP version at `http://example.com/2016/01/01/amp-on/amp/`. If you do not have [pretty permalinks](https://codex.wordpress.org/Using_Permalinks#mod_rewrite:_.22Pretty_Permalinks.22) enabled, you can do the same thing by appending `?amp=1`, i.e. `http://example.com/?p=123&=1` diff --git a/readme.txt b/readme.txt index 2ec3e22580a..6f185e81543 100644 --- a/readme.txt +++ b/readme.txt @@ -12,7 +12,7 @@ Enable Accelerated Mobile Pages (AMP) on your WordPress site. == Description == -AMP, the WordPress way. Bring the speed and features of the open source [AMP project](https://www.ampproject.org/) to your site. +Bring the speed and features of the open source [AMP project](https://www.ampproject.org/) to your site, the WordPress way. With the plugin active, all posts on your site will have AMP-compatible versions, accessible by appending `/amp/` to the end your post URLs. For example, if your post URL is `http://example.com/2016/01/01/amp-on/`, you can access the AMP version at `http://example.com/2016/01/01/amp-on/amp/`. If you do not have [pretty permalinks](https://codex.wordpress.org/Using_Permalinks#mod_rewrite:_.22Pretty_Permalinks.22) enabled, you can do the same thing by appending `?amp=1`, i.e. `http://example.com/?p=123&=1` From 178e3161990a8d83ac597153856aa3db967f3241 Mon Sep 17 00:00:00 2001 From: Ryan Kienstra Date: Thu, 5 Apr 2018 14:49:36 -0500 Subject: [PATCH 08/18] Update caveat about AMP not appearing, thanks to Weston's suggestion. The previous statement wasn't accurate in the case of 'Native AMP' or 'Paired Mode.'. So update it, based on Weston's suggestion. --- readme.md | 2 +- readme.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/readme.md b/readme.md index e3aefa7c4ff..cbc3d28aeb0 100644 --- a/readme.md +++ b/readme.md @@ -28,7 +28,7 @@ Your theme can also use [Paired Mode](https://github.com/Automattic/amp-wp/wiki/ "Native AMP" and "Paired Mode" add full support for commenting and widgets. -This plugin only creates AMP content but does not automatically display it to your users when they visit from a mobile device. That is handled by AMP consumers such as Google Search. For more details, see the [AMP Project FAQ](https://www.ampproject.org/docs/support/faqs.html). +If your theme doesn't support `'amp'`, this will use basic legacy post templates for AMP consumers like Google Search and Twitter. And when visiting the site, the AMP content won't normally appear without appending strings to the URL like `/amp` or `?amp`. Follow along with or [contribute](https://github.com/Automattic/amp-wp/blob/develop/contributing.md) to the development of this plugin [on GitHub](https://github.com/Automattic/amp-wp). For more information on the plugin, how the plugin works and how to configure and extend it, please see the [project wiki](https://github.com/Automattic/amp-wp/wiki). diff --git a/readme.txt b/readme.txt index 6f185e81543..27fc4baa7a0 100644 --- a/readme.txt +++ b/readme.txt @@ -24,7 +24,7 @@ Your theme can also use [Paired Mode](https://github.com/Automattic/amp-wp/wiki/ "Native AMP" and "Paired Mode" add full support for commenting and widgets. -This plugin only creates AMP content but does not automatically display it to your users when they visit from a mobile device. That is handled by AMP consumers such as Google Search. For more details, see the [AMP Project FAQ](https://www.ampproject.org/docs/support/faqs.html). +If your theme doesn't support `'amp'`, this will use basic legacy post templates for AMP consumers like Google Search and Twitter. And when visiting the site, the AMP content won't normally appear without appending strings to the URL like `/amp` or `?amp`. Follow along with or [contribute](https://github.com/Automattic/amp-wp/blob/develop/contributing.md) to the development of this plugin [on GitHub](https://github.com/Automattic/amp-wp). For more information on the plugin, how the plugin works and how to configure and extend it, please see the [project wiki](https://github.com/Automattic/amp-wp/wiki). From 74c4197694ad34f443a593147196526903af94fd Mon Sep 17 00:00:00 2001 From: Ryan Kienstra Date: Thu, 5 Apr 2018 14:54:53 -0500 Subject: [PATCH 09/18] Bump the 'Tested up to' line to 4.9.5. Though this was just released, we will of course test with this version. --- readme.md | 2 +- readme.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/readme.md b/readme.md index cbc3d28aeb0..fc93455d15d 100644 --- a/readme.md +++ b/readme.md @@ -7,7 +7,7 @@ Enable Accelerated Mobile Pages (AMP) on your WordPress site. **Contributors:** [batmoo](https://profiles.wordpress.org/batmoo), [joen](https://profiles.wordpress.org/joen), [automattic](https://profiles.wordpress.org/automattic), [potatomaster](https://profiles.wordpress.org/potatomaster), [albertomedina](https://profiles.wordpress.org/albertomedina), [google](https://profiles.wordpress.org/google), [xwp](https://profiles.wordpress.org/xwp), [westonruter](https://profiles.wordpress.org/westonruter) **Tags:** [amp](https://wordpress.org/plugins/tags/amp), [mobile](https://wordpress.org/plugins/tags/mobile) **Requires at least:** 4.7 -**Tested up to:** 4.9 +**Tested up to:** 4.9.5 **Stable tag:** 0.6.0 **License:** [GPLv2 or later](http://www.gnu.org/licenses/gpl-2.0.html) **Requires PHP:** 5.3 diff --git a/readme.txt b/readme.txt index 27fc4baa7a0..841bb373d2a 100644 --- a/readme.txt +++ b/readme.txt @@ -2,7 +2,7 @@ Contributors: batmoo, joen, automattic, potatomaster, albertomedina, google, xwp, westonruter Tags: amp, mobile Requires at least: 4.7 -Tested up to: 4.9 +Tested up to: 4.9.5 Stable tag: 0.6.0 License: GPLv2 or later License URI: http://www.gnu.org/licenses/gpl-2.0.html From 8ba84515094759175497b4b623d22f5f9934004c Mon Sep 17 00:00:00 2001 From: Ryan Kienstra Date: Thu, 5 Apr 2018 16:53:07 -0500 Subject: [PATCH 10/18] Add to changelog, including sanitizer updates and test coverage. Also, updated build scripts, and using components outside AMP. --- readme.md | 11 +++++++++-- readme.txt | 11 +++++++++-- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/readme.md b/readme.md index fc93455d15d..30ce949625b 100644 --- a/readme.md +++ b/readme.md @@ -65,17 +65,24 @@ Follow along with or [contribute](https://github.com/Automattic/amp-wp/blob/deve ### 0.7 (unreleased) ### - Render an entire site as "Native AMP" if the theme calls `add_theme_support( 'amp' )`. See [#857](https://github.com/Automattic/amp-wp/pull/857). Props westonruter, kaitnyl, ThierryA. - Use "Paired Mode" if the theme calls `add_theme_support( 'amp' )` and passes a `'template_dir'` value for the AMP templates. See [#856](https://github.com/Automattic/amp-wp/pull/856). Props westonruter, kaitnyl. +- Allow full Customization when the theme supports `'amp'`. See [#952](https://github.com/Automattic/amp-wp/pull/952). Props westonruter. - Add support for all default WordPress widgets. See [#921](https://github.com/Automattic/amp-wp/pull/921), [#917](https://github.com/Automattic/amp-wp/pull/917). Props kienstra, westonruter. - Add support for more default embeds: Issuu, Post, Meetup, Reddit, Screencast, Tumblr, and WordPress Plugin Directory. See [#889](https://github.com/Automattic/amp-wp/pull/889). Props kaitnyl. - Allow native WordPress commenting, in fully valid AMP. See [#871](https://github.com/Automattic/amp-wp/pull/871), [#909](https://github.com/Automattic/amp-wp/pull/909). Props DavidCramer, westonruter. - Optionally use `` to display comments, avoiding full-page refreshes on adding comments. See [#1029](https://github.com/Automattic/amp-wp/pull/1029). Props DavidCramer, westonruter. -- Add a complete UI for validation errors, including invalid tags and attributes. See [#971](https://github.com/Automattic/amp-wp/pull/971). Props westonruter, kienstra. +- Add a complete UI for validation errors, including invalid tags and attributes. See [#971](https://github.com/Automattic/amp-wp/pull/971), [#1016](https://github.com/Automattic/amp-wp/pull/1016). Props westonruter, kienstra. - On activating a plugin, validate a front-end page and display a notice if there were errors. See [#971](https://github.com/Automattic/amp-wp/pull/971). Props westonruter, kienstra. - Creation of AMP-related notifications, on entering invalid content in the 'classic' editor. See [#912](https://github.com/Automattic/amp-wp/pull/912/). Props kienstra, westonruter, ThierryA. - Add output buffering, ensuring the entire page is valid AMP. See [#929](https://github.com/Automattic/amp-wp/pull/929), [#857](https://github.com/Automattic/amp-wp/pull/857). Props westonruter, ThierryA. -- Update the generated sanitizer file to the AMP spec, and simplify the file that generates it. See [#929](https://github.com/Automattic/amp-wp/pull/929). Props westonruter. - Add validation of host names in URLs. See [#983](https://github.com/Automattic/amp-wp/pull/983). Props rubengonzalezmrf. - Add wp-cli scripts to test AMP support of comments and widgets. See [#924](https://github.com/Automattic/amp-wp/pull/924), [#859](https://github.com/Automattic/amp-wp/pull/859). Props DavidCramer, kienstra. +- Improve test coverage, including for `AMP_Theme_Support`. See [#1034](https://github.com/Automattic/amp-wp/pull/1034). Props DavidCramer, kienstra. +- Update the generated sanitizer file to the AMP spec, and simplify the file that generates it. See [#929](https://github.com/Automattic/amp-wp/pull/929), [#926](https://github.com/Automattic/amp-wp/pull/926). Props westonruter. +- Several sanitizer updates, including for styles, and preventing valid tags from being removed. See [#935](https://github.com/Automattic/amp-wp/pull/935), [#944](https://github.com/Automattic/amp-wp/pull/944), [#952](https://github.com/Automattic/amp-wp/pull/952). Props westonruter, davisshaver. +- Improve sanitization of ``, ``, and ``. See [#937](https://github.com/Automattic/amp-wp/pull/937), [#1054](https://github.com/Automattic/amp-wp/pull/1054). Props kienstra, amedina. +- Allow use of AMP components outside of AMP documents, including in [PWA](https://developers.google.com/web/progressive-web-apps/). See [#1013](https://github.com/Automattic/amp-wp/pull/1013). Props westonruter. +- Access the AMP query var with `amp_get_slug()`, instead of `AMP_QUERY_VAR`. See [#986](https://github.com/Automattic/amp-wp/pull/986). Props westonruter, mjangda. +- Update build scripts, including PHP versions in `.travis.yml`. See [#1058](https://github.com/Automattic/amp-wp/pull/1058/), [#949](https://github.com/Automattic/amp-wp/pull/949). Props westonruter. See [0.7 milestone](https://github.com/Automattic/amp-wp/milestone/6?closed=1). diff --git a/readme.txt b/readme.txt index 841bb373d2a..08743dcc0df 100644 --- a/readme.txt +++ b/readme.txt @@ -48,17 +48,24 @@ Follow along with or [contribute](https://github.com/Automattic/amp-wp/blob/deve - Render an entire site as "Native AMP" if the theme calls `add_theme_support( 'amp' )`. See [#857](https://github.com/Automattic/amp-wp/pull/857). Props westonruter, kaitnyl, ThierryA. - Use "Paired Mode" if the theme calls `add_theme_support( 'amp' )` and passes a `'template_dir'` value for the AMP templates. See [#856](https://github.com/Automattic/amp-wp/pull/856). Props westonruter, kaitnyl. +- Allow full Customization when the theme supports `'amp'`. See [#952](https://github.com/Automattic/amp-wp/pull/952). Props westonruter. - Add support for all default WordPress widgets. See [#921](https://github.com/Automattic/amp-wp/pull/921), [#917](https://github.com/Automattic/amp-wp/pull/917). Props kienstra, westonruter. - Add support for more default embeds: Issuu, Post, Meetup, Reddit, Screencast, Tumblr, and WordPress Plugin Directory. See [#889](https://github.com/Automattic/amp-wp/pull/889). Props kaitnyl. - Allow native WordPress commenting, in fully valid AMP. See [#871](https://github.com/Automattic/amp-wp/pull/871), [#909](https://github.com/Automattic/amp-wp/pull/909). Props DavidCramer, westonruter. - Optionally use `` to display comments, avoiding full-page refreshes on adding comments. See [#1029](https://github.com/Automattic/amp-wp/pull/1029). Props DavidCramer, westonruter. -- Add a complete UI for validation errors, including invalid tags and attributes. See [#971](https://github.com/Automattic/amp-wp/pull/971). Props westonruter, kienstra. +- Add a complete UI for validation errors, including invalid tags and attributes. See [#971](https://github.com/Automattic/amp-wp/pull/971), [#1016](https://github.com/Automattic/amp-wp/pull/1016). Props westonruter, kienstra. - On activating a plugin, validate a front-end page and display a notice if there were errors. See [#971](https://github.com/Automattic/amp-wp/pull/971). Props westonruter, kienstra. - Creation of AMP-related notifications, on entering invalid content in the 'classic' editor. See [#912](https://github.com/Automattic/amp-wp/pull/912/). Props kienstra, westonruter, ThierryA. - Add output buffering, ensuring the entire page is valid AMP. See [#929](https://github.com/Automattic/amp-wp/pull/929), [#857](https://github.com/Automattic/amp-wp/pull/857). Props westonruter, ThierryA. -- Update the generated sanitizer file to the AMP spec, and simplify the file that generates it. See [#929](https://github.com/Automattic/amp-wp/pull/929). Props westonruter. - Add validation of host names in URLs. See [#983](https://github.com/Automattic/amp-wp/pull/983). Props rubengonzalezmrf. - Add wp-cli scripts to test AMP support of comments and widgets. See [#924](https://github.com/Automattic/amp-wp/pull/924), [#859](https://github.com/Automattic/amp-wp/pull/859). Props DavidCramer, kienstra. +- Improve test coverage, including for `AMP_Theme_Support`. See [#1034](https://github.com/Automattic/amp-wp/pull/1034). Props DavidCramer, kienstra. +- Update the generated sanitizer file to the AMP spec, and simplify the file that generates it. See [#929](https://github.com/Automattic/amp-wp/pull/929), [#926](https://github.com/Automattic/amp-wp/pull/926). Props westonruter. +- Several sanitizer updates, including for styles, and preventing valid tags from being removed. See [#935](https://github.com/Automattic/amp-wp/pull/935), [#944](https://github.com/Automattic/amp-wp/pull/944), [#952](https://github.com/Automattic/amp-wp/pull/952). Props westonruter, davisshaver. +- Improve sanitization of ``, ``, and ``. See [#937](https://github.com/Automattic/amp-wp/pull/937), [#1054](https://github.com/Automattic/amp-wp/pull/1054). Props kienstra, amedina. +- Allow use of AMP components outside of AMP documents, including in [PWA](https://developers.google.com/web/progressive-web-apps/). See [#1013](https://github.com/Automattic/amp-wp/pull/1013). Props westonruter. +- Access the AMP query var with `amp_get_slug()`, instead of `AMP_QUERY_VAR`. See [#986](https://github.com/Automattic/amp-wp/pull/986). Props westonruter, mjangda. +- Update build scripts, including PHP versions in `.travis.yml`. See [#1058](https://github.com/Automattic/amp-wp/pull/1058/), [#949](https://github.com/Automattic/amp-wp/pull/949). Props westonruter. See [0.7 milestone](https://github.com/Automattic/amp-wp/milestone/6?closed=1). From c054aec569b9ab2c457f854b07353e4a21d7a7b2 Mon Sep 17 00:00:00 2001 From: Ryan Kienstra Date: Thu, 5 Apr 2018 18:21:17 -0500 Subject: [PATCH 11/18] Add items to changelog, including JSON fix. This issue with CDATA was in a support topic. Also, add a PR to the line. And add a line for . --- readme.md | 4 +++- readme.txt | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/readme.md b/readme.md index 30ce949625b..48893415fe9 100644 --- a/readme.md +++ b/readme.md @@ -69,10 +69,11 @@ Follow along with or [contribute](https://github.com/Automattic/amp-wp/blob/deve - Add support for all default WordPress widgets. See [#921](https://github.com/Automattic/amp-wp/pull/921), [#917](https://github.com/Automattic/amp-wp/pull/917). Props kienstra, westonruter. - Add support for more default embeds: Issuu, Post, Meetup, Reddit, Screencast, Tumblr, and WordPress Plugin Directory. See [#889](https://github.com/Automattic/amp-wp/pull/889). Props kaitnyl. - Allow native WordPress commenting, in fully valid AMP. See [#871](https://github.com/Automattic/amp-wp/pull/871), [#909](https://github.com/Automattic/amp-wp/pull/909). Props DavidCramer, westonruter. -- Optionally use `` to display comments, avoiding full-page refreshes on adding comments. See [#1029](https://github.com/Automattic/amp-wp/pull/1029). Props DavidCramer, westonruter. - Add a complete UI for validation errors, including invalid tags and attributes. See [#971](https://github.com/Automattic/amp-wp/pull/971), [#1016](https://github.com/Automattic/amp-wp/pull/1016). Props westonruter, kienstra. - On activating a plugin, validate a front-end page and display a notice if there were errors. See [#971](https://github.com/Automattic/amp-wp/pull/971). Props westonruter, kienstra. - Creation of AMP-related notifications, on entering invalid content in the 'classic' editor. See [#912](https://github.com/Automattic/amp-wp/pull/912/). Props kienstra, westonruter, ThierryA. +- Optionally use `` to display comments, avoiding full-page refreshes on adding comments. And enable making requests for an ``, like for displaying posts. See [#1029](https://github.com/Automattic/amp-wp/pull/1029), [#915](https://github.com/Automattic/amp-wp/pull/915). Props DavidCramer, westonruter. +- Support ``, enabling more dynamic elements. See [#895](https://github.com/Automattic/amp-wp/pull/895). Props westonruter. - Add output buffering, ensuring the entire page is valid AMP. See [#929](https://github.com/Automattic/amp-wp/pull/929), [#857](https://github.com/Automattic/amp-wp/pull/857). Props westonruter, ThierryA. - Add validation of host names in URLs. See [#983](https://github.com/Automattic/amp-wp/pull/983). Props rubengonzalezmrf. - Add wp-cli scripts to test AMP support of comments and widgets. See [#924](https://github.com/Automattic/amp-wp/pull/924), [#859](https://github.com/Automattic/amp-wp/pull/859). Props DavidCramer, kienstra. @@ -80,6 +81,7 @@ Follow along with or [contribute](https://github.com/Automattic/amp-wp/blob/deve - Update the generated sanitizer file to the AMP spec, and simplify the file that generates it. See [#929](https://github.com/Automattic/amp-wp/pull/929), [#926](https://github.com/Automattic/amp-wp/pull/926). Props westonruter. - Several sanitizer updates, including for styles, and preventing valid tags from being removed. See [#935](https://github.com/Automattic/amp-wp/pull/935), [#944](https://github.com/Automattic/amp-wp/pull/944), [#952](https://github.com/Automattic/amp-wp/pull/952). Props westonruter, davisshaver. - Improve sanitization of ``, ``, and ``. See [#937](https://github.com/Automattic/amp-wp/pull/937), [#1054](https://github.com/Automattic/amp-wp/pull/1054). Props kienstra, amedina. +- Fix an issue where the JSON inside `