Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't preload hero images #127

Closed
schlessera opened this issue Apr 6, 2021 · 0 comments · Fixed by #135
Closed

Don't preload hero images #127

schlessera opened this issue Apr 6, 2021 · 0 comments · Fixed by #135
Labels
Optimizer P0 High Priority
Milestone

Comments

@schlessera
Copy link
Collaborator

From @sebastianbenz on ampproject/amp-toolbox#1132:

We can't tell whether a hero image is responsive and is loaded depending
on viewport size. The current implementation will always preload hero
images, which means images might be preloaded even if they are not
visible on the page. This PR reverts this behavior and disables
preload generation for hero images.

The only exception is when an image defines a media attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Optimizer P0 High Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants