feat: add stream support #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhukaihan
force-pushed
the
add-stream-support
branch
from
428aef2 to
2ea4a09
Compare
zhukaihan
commented
Feb 27, 2024
zhukaihan
commented
Feb 27, 2024
zhukaihan
commented
Feb 27, 2024
zhukaihan
commented
Feb 29, 2024
zhukaihan
commented
Mar 8, 2024
bgiori
approved these changes
Mar 14, 2024
|
Just make the config changes and you're good to go |
zhukaihan
force-pushed
the
add-stream-support
branch
from
d2899de to
edaba25
Compare
zhukaihan
force-pushed
the
add-stream-support
branch
from
edaba25 to
332a8df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Uses the stream flag API from experiment-core to produce SDK that receives flag configs updates from server. It should replace constant polling. Currently it is disabled by default and falls back to polling if any fatal error encountered, server 501 or retry reached maximum. It retries every 15 seconds.
Checklist