Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AmplitudeCookie should use relative import #35

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

tyiuhc
Copy link
Collaborator

@tyiuhc tyiuhc commented Oct 25, 2023

Summary

Update AmplitudeCookie to use relative imports

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@@ -3,7 +3,7 @@ import { ExperimentUser } from 'src/types/user';

const API_KEY = 'server-qz35UwzJ5akieoAdIgzM4m9MIiOLXLoz';

const testUser: ExperimentUser = { user_id: 'test_user' };
const testUser: ExperimentUser = { user_id: '[email protected]' };
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reason for change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistake on my part, this is not needed - was testing for something on my local environment

@tyiuhc tyiuhc force-pushed the cookie-relative-import branch from 91f2129 to 25a4d40 Compare October 25, 2023 17:04
@tyiuhc tyiuhc merged commit e473e84 into main Oct 25, 2023
8 checks passed
@tyiuhc tyiuhc deleted the cookie-relative-import branch October 25, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants