-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remote.Client): Add current context to Fetch and FetchV2 #29
Conversation
Well, I'm not an expert in Go, but, after investigating a little bit my problem, I can instrument the underlying |
Hey @hbiarge thanks so much for submitting this PR. Unfortunately I don't want to break the existing API on the client for Can you add |
Sure, it makes totally sense. |
Ready for review @bgiori... |
# [1.6.0](v1.5.0...v1.6.0) (2024-08-26) ### Features * **remote.Client:** Add current context to Fetch and FetchV2 ([#29](#29)) ([2113bed](2113bed))
🎉 This issue has been resolved in version 1.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Add a field in the Config type to provide the internal http.Client the remote.Client is going to use.No breaking changes. Same default behaviour as before.Allow instrumenting remote http calls providing a wrapped http.Client.Pass the current Context to
Fetch
andFetchV2
to enable distributed tracing.Fixes #28
Checklist
Does your PR have a breaking change?: No