New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In service worker environment, globalScope.document.cookie setting will throw #925

Open

jimexist opened this issue Dec 3, 2024 · 0 comments

Labels

bug

jimexist commented Dec 3, 2024 •

edited

Loading

Expected Behavior

In service worker, globalScope.document.cookie should be checked before accessing it's value.

Amplitude-TypeScript/packages/analytics-client-common/src/storage/cookie.ts

Line 88 in 368f7d3

globalScope.document.cookie = str;

Current Behavior

It will throw and a console error will be logged

Possible Solution

guard against the possibility of undefined in service worker environment

Steps to Reproduce

Environment

JS SDK Version:
Installation Method:
Browser and Version:

The text was updated successfully, but these errors were encountered:

jimexist added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment