Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support getVersion in React Native app #219

Closed
peteroid opened this issue Jan 13, 2020 · 0 comments · Fixed by #201
Closed

Support getVersion in React Native app #219

peteroid opened this issue Jan 13, 2020 · 0 comments · Fixed by #201

Comments

@peteroid
Copy link

Currently, the app version is not being logged. The prop version_name is null in the form data of the POST api.amplitude.com requests.

However, we can explicitly set the version name as following.

import { getVersion } from 'react-native-device-info'
import Amplitude from 'amplitude-js'
// ...
Amplitude.getInstance().setVersionName(getVersion())
// ...

Is it possible to add getVersion to the array here https://github.com/amplitude/Amplitude-JavaScript/blob/master/src/amplitude-client.js#L191 ?

ref:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant