Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a Dev - I want to change the CI workflow on the plugins repository to publish a beta version only on comment #7499

Closed
abrl91 opened this issue Nov 24, 2023 · 1 comment · Fixed by amplication/plugins#294, amplication/plugins#303 or amplication/plugins#304
Assignees
Milestone

Comments

@abrl91
Copy link
Contributor

abrl91 commented Nov 24, 2023

Related issue: #7441

Current implementation

A new plugin beta version is published on every new and synchronized pull request.

New requirement

On every comment on the PR a new beta version of a plugin will be published with the same format that we have in the current implementation: <version in package.json>-beta.pr-<pr number>.<commit short sha (7 chars)>
i.e. for pr # 7441 1.2.1-beta.pr-7441.979a26c

  • get affected plugins
  • execute a publish dry run for every plugin that was changed and check if the current version can be published
  • publish
@abrl91 abrl91 self-assigned this Nov 24, 2023
@overbit
Copy link
Contributor

overbit commented Nov 24, 2023

@abrl91 ⚠️
Version bump validation must happen on PR for every commit as we don't want to merge a PR with changes on a plugin that has not been version bumped otherwise we will have a failing publish pipeline in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment