-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inline feature to the plugin #157
Comments
This feature will encourage more person to use webpack instead of gulp. For me, I am using gulp for resources inline and image sprites. |
I study the source code, and find that it maybe difficult to add code to make files inline. But I think it is ok to add attributes or queries for next plugin to complete the resource inline jobs. For example, I can pass options like this: var htmlPlugin = new HtmlWebpackPlugin({ Then the result gives me: or <script src="xxx.js?__inline"></script> or <script src="xxx.js" inline></script>I don't think this features will server for resource inline. It can server for other attributes like asyc, defer and so on. If you think this is good, I can add this feature for the plugin and develop another plugin exclusively for resource inline. Best regards, Lee |
I could add an event so you might inline everything during this event in another plugin - would that be a proper solution? |
Added events which should allow you inlining the files: |
link 404 |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hi Jan, I am considering to help add inline features to the plugin. What do you think?
In our business, we usually sth like <script src="xxx.js?__inline"></script> to make js or other static files inline in html files. This will greatly help us optimize the speed in certain circumstance.
Best regards,
Lee
The text was updated successfully, but these errors were encountered: