Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] Add missing Unit Tests on PragmaticRawValueValidator #40

Open
5 tasks
gmorel opened this issue Feb 10, 2017 · 0 comments
Open
5 tasks

[QA] Add missing Unit Tests on PragmaticRawValueValidator #40

gmorel opened this issue Feb 10, 2017 · 0 comments
Labels
status:help-wanted status:ready type:easy-pick type:enhancement
Milestone
1.0.0

Comments

@gmorel
Copy link
Member

gmorel commented Feb 10, 2017

Pain Point

We have only 1 method Unit Tested on Imedia\Ammit\UI\Resolver\Validator\PragmaticRawValueValidator

TODO

In tests/units/UI/Resolver/Validator/PragmaticRawValueValidator.php

  • Unit Test mustBeUuid()
    • test_it_gets_value_even_if_uuid_invalid
    • test_it_gets_value_even_if_uuid_valid
  • Unit Test mustHaveLengthBetween()
    • test_it_gets_value_even_if_length_invalid
    • test_it_gets_value_even_if_length_valid
  • Unit Test mustBeEmailAddress()
    • test_it_gets_value_even_if_email_invalid
    • test_it_gets_value_even_if_email_valid
  • Rename test_it_gets_value_even_if_string_empty_detected
    • into test_it_gets_value_even_if_string_empty_invalid
  • Rename test_it_gets_value_even_if_valid
    • into test_it_gets_value_even_if_string_empty_valid

Atoum Doc:
http://atoum.org/

Unit test can be run via:

docker/bin/php bin/atoum tests/units/UI/Resolver/Validator/PragmaticRawValueValidator.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:help-wanted status:ready type:easy-pick type:enhancement
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@gmorel @jeremy-hyde