Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow providing a custom DNS resolver #26

Open
gnuletik opened this issue Nov 17, 2023 · 1 comment · May be fixed by #27
Open

Allow providing a custom DNS resolver #26

gnuletik opened this issue Nov 17, 2023 · 1 comment · May be fixed by #27

Comments

@gnuletik
Copy link

gnuletik commented Nov 17, 2023 •
edited
Loading

A new resolver is created at the start of the LookupIP and LookupASN functions.

ipisp/dnsclient.go

Line 18 in a1960f6

var r net.Resolver

Would it be possible to provide a custom resolver in the following way?

client := ipisp.NewClient(&net.Resolver{})
client.LookupIP(...)
client.LookupASN(...)
@ammario
Copy link
Owner

ammario commented Nov 17, 2023 •
edited
Loading

I see the value in that. We could follow suit of net/http and have package-level methods that use a DefaultDNSClient but then give users the ability to specify their own. Unfortunately I don't have time to work on this right now but I welcome contributions.

@babariviere babariviere linked a pull request Nov 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add client to allow passing custom resolver babariviere/ipisp
2 participants
@ammario @gnuletik