-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance issue #16
Comments
@urunky Thanks for opening this issue, I will look into why there is such performance drop and report back. |
Okay so I tested it, I am getting 60fps when there is only one ad in the Flatlist at a time, If i am rendering more than one, the fps drops and that is because you should not render more than one NativeAd at a time. With one ad, i am getting 60fps in dev mode with ui components. |
@ammarahm-ed Thanks for fast reply!! Maybe my explanation was not exact. Like you said, If I use only one nativead, the performance is not bad(~40fps) in debug mode (because my testing device is very entry model). But I'm using two nativeads, the fps drops to 5~20 fps. I think I'd be better use only one nativead this time, and Thanks again for your good lib!!! |
@urunky I will look into this to find the reason why the frames are dropping when there are multiple ads in the same screen. its a strange behavior. but until then you can make sure there is only ad rendered in the list at one time. |
Hello @ammarahm-ed I'm using Samsung M30
I have a single ad on one screen, |
@ammarahm-ed is there any direction I can look for ? I would like to help in solving this issue |
@paddy57 until now I have only been able to improve the performance incrementally at a very small level by removing some nesting of views on native side, but I am still unable to find the exact reason due to which the UI-thread is being blocked. You can look at the code on Native Android side to see if you can find any bottlenecks in code that might be the cause of the issue. |
@ammarahm-ed can you tell me how did you improve the frame rate? |
The issue was relatef to a Hack that i was using to make sure views were rendered properly but I realized it was doing more bad than good. You can update to the latest release. |
First, thank you for your great work!!!!!
I'm very happy to use your libraray. This library is what I'm looking for.
I'm using your library for my new developing android app.
I'm using 'FlatList' and using 'renderItem' for rendering NativeAdView.
NativeAdView is top of the list items. total 13 items are rendered.
But the performance is not good as I expected.
So I tested some cases.
all the results are actual device in debug mode. just after load native ad, no interaction.
device profile : samsung galaxy m20 ( Android 9)
react native : 0.61.5
library version : 0.2.6
Not render NativeAd
UI : 60 / JS: 60
NativeAdView without any children
UI : 8~35 / JS: 30-35
UI : 5 ~ 17 / JS: 8 ~ 20
UI : 5 ~ 15 / JS : 9 ~ 12
When using release mode the performance is little bit better but not good. (I guess it's not over 30fps)
did you have any performance when testing on android devices?
The text was updated successfully, but these errors were encountered: