-
Notifications
You must be signed in to change notification settings - Fork 125
Use happypack with ExtractTextPlugin #12
Comments
So the plugin itself should work if you just feed it the loaders you're already feeding to happypack (I'm only assuming) but I know for sure that less/style/css loaders do NOT work right now because they're using the pitch methods. I've started a branch to address this, and I did get part of it to work but I'm not sure if I want to go through with it it because it's making things really complicated. How many style files do you have? |
A lot (477 to be precise) - I am quite sure it is my main bottle neck. |
Ok yeah that might be worth it then. We use SASS but without webpack. Any chance your project is open that I may test against? |
Unfortunately it is not open and I am not allowed to open in 👎 |
Ok, no problem. I'll update this ticket when there's something ready to be tested, but it's probably gonna be a while. |
Absolutely, thanks a lot! Looking forward |
👍 for supporting ExtractTextPlugin and Style loaders Sass is also the main bottle neck in our project builds... |
I've some free time tomorrow, will work on this and see if it can be done without a lot of piggybacking against webpack's compilation. |
So, now that style/css/sass loaders are working (in #15), I've taken a look at the source of extract-text-webpack-plugin and unfortunately, I don't think it will ever be supported in this architecture. The loader itself generates a child compiler and hooks into the main compilation, while the plugin reaches out to the loader(s). The loaders modify their own contexts at run-time and actually modify the entirety of the chunk and its assets, then they also use TL;DR - I don't have the time to bother with that plugin. Perhaps consider not using webpack for your stylesheets; at my work we don't and it's just fine (~273 sass files) - we use plain node-sass behind a grunt task. |
Sorry guys, gonna close this one. |
Can you guys check my comment in #14 (comment) about using ExtractText and see if that trick makes it work for you? |
Absolutely! Should I just take last version from npm? I cannot find any particular branch for now. |
Yes! Anything > 2.0 should be ok! |
I did not go through all my application, but it looks like it it is working at the moment. |
Would it be possible to provide an example about how to use HappyPack with
ExtractTextPlugin
?The text was updated successfully, but these errors were encountered: