Run iCub telemetry server and openMCT visualizer in one line command: Iteration 2/2 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion>' in a child process
- Replaced the hardcoded nvm.sh path with path computed from NVM_DIR.
- Used require('paht').join to build paths, for more portability.
- Applied 'nvmVersion' input parameter.
- 'nvm use \<version\>' can be run from anywhere in the repo, since
it only impacts the shell environment variables.
nunoguedelha
force-pushed
the
feature/run-all-script-2
branch
from
79c6fca
to
392b05c
Compare
- Call the method in the main script.
- fix the node.js version selection: the 'PATH' variable was missing
among those updated by "nvm use vxxx" command.
- Set the updated variables {PATH,NVM_INC,NVM_BIN} in the options of
the spawn command running the "npm start" command.
- Warining: do not use "=" operator to copy objects, but instead the
'Object.assign()' method.
- Inside the callbacks, for 'this' to be the 'OpenMctServerHandler'
object instead of the callback caller, we need to back it up in a
variable 'embeddedThis'.
|
The child process running the openmctStaticServer is already properly launched by the iCubTelemVizServer, such that we run everything by running "npm start" in the openmctStaticServer folder. But stopping the servers or aborting is still not working properly, I'm still working on it. |
Closed
3 tasks
…nstead of 'execSync' command.
- Refactor 'OpenMctServerHandler.setNvmVersion' fo an eventual later use.
- Add '. ${NVM_DIR}/nvm.sh; nvm use vX.X.X;' in the start scripts of
'iCubTelemVizServer' and 'openmctStaticServer'. The first instruction
defines the 'nvm' function, while the second sets the nodejs version.
In this case, the 'npm' process running the start script can be launched
by a 'spawn' command. Unlike running the command 'nvm use vX.X.X' directly
through 'spawn', using here an intermediate script ("start") avoids the
EACCES problem encountered previously.
nunoguedelha
force-pushed
the
feature/run-all-script-2
branch
from
44ba79d
to
6b94e99
Compare
|
I've implemented a small improvement/simplification for handling the Node.js versions.
On top of that, the fix for properly closing the servers will be tracked in #34 , refer to #25 (comment). So, I would consider the work complete here. |
|
This actually simplifies the documentation. The README will be updated in #22 where also tracked the other feedback from @traversaro . |
|
Hi @S-Dafarra , I'm adding you as a reviewer for avoiding to load @traversaro with this. |
S-Dafarra
reviewed
Sep 28, 2021
S-Dafarra
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #25 . (iteration 2/2)