Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkerAllocator::maintain is never called #713

Open
wez opened this issue Nov 26, 2020 · 1 comment
Open

MarkerAllocator::maintain is never called #713

wez opened this issue Nov 26, 2020 · 1 comment
Labels

Comments

@wez
Copy link

wez commented Nov 26, 2020

Description

Apologies if I've overlooked something, but AFAICT, nothing ever calls this trait method.
Is this something that I need to setup for myself?
I've been using https://specs.amethyst.rs/docs/tutorials/13_saveload.html as a reference to
use with my own allocator impl, and that doesn't give guidance on how maintain is called.

Meta

Rust version: rustc 1.48.0 (7eac88abb 2020-11-16)
Specs version / commit: 0.16 but I also looked through 1fd81cd and didn't find any callers
Operating system: N/A, but I'm on Linux.

Reproduction

$ cd specs
$ grep -r maintain .
<none of the results show maintain being called with any arguments>

Expected behavior

Either something should call maintain inside specs, or the documentation should explain how best to perform that maintenance!

@wez wez added the bug label Nov 26, 2020
@LoganDark
Copy link

It looks like maintain is a method used to commit atomic operations to your backing storage. See this section for a bit of context.

Shouldn't it be called by World::maintain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants