Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata #232

Closed
Aceeri opened this issue Jul 26, 2017 · 3 comments
Closed

Metadata #232

Aceeri opened this issue Jul 26, 2017 · 3 comments

Comments

@Aceeri
Copy link
Member

Aceeri commented Jul 26, 2017

The "wrapper" storages we have now with FlaggedStorage and ChangedStorage aren't very flexible. Since I'm sure someone down the line will want to check for changes for some component that doesn't have the wrapper storage. (Since I've run into this plenty of times already when trying to implement UI stuff with specs to the point of where I just add the FlaggedStorage for all the UI components so I don't have to worry about it anymore.)

We might be able to add some Vec<Box<AddonTrait>> and abstract away the "real" storage (DenseVecStorage, HashMapStorage, etc.) so they can't be modified except through some interface.

@Aceeri Aceeri changed the title Addon Storages? Metadata Nov 15, 2017
@Aceeri
Copy link
Member Author

Aceeri commented Nov 15, 2017

Coming back to this I have something working and actually kind of nice: https://gist.github.com/Aceeri/39b23eb18bf05848ee44c21c5e34e14a

@Aceeri Aceeri mentioned this issue Nov 15, 2017
@Rhuagh
Copy link
Member

Rhuagh commented May 9, 2018

Should this be closed as the PR was rejected in favor or Tracked?.

@torkleyy
Copy link
Member

torkleyy commented May 9, 2018

I think so.

@torkleyy torkleyy closed this as completed May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants