-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom colors for lyrics #191
Comments
Can be implemented as an additional function through incoming parameters Any ideas with other color options? |
That's really nice! Yeah, no problem, let's keep #121212 for the background color then. This could be another color scheme: I don't have any other color schemes for now, as I don't know what you might like. A, you can also notice that the link to the color scheme has all the hexadecimals colors in the same order they appear on the site: 121212-67697c-c2c2c2-008148 It even has an "Adjust palette" section, where you can tweak the colors some more, like here: I tried to check the contrast of the colors in Firefox for Spotify web player with my first color scheme, but unfortunately it doesn't work. I did to see if the different colored text on that black background passed the checks. You can see down below that white 4 on that black orange didn't pass the check, getting a 2.45 rating. Chrome had something similar in the past, but they removed it in the latest versions, it was called CSS Overview. I'll see tomorrow if I can get my hands on an older version of Chrome and test it out. I just want to do this mostly out of curiosity. What do you think, should we check the color contrast or should we just wing it? From the looks of it, Spotify didn't bother with it, since I've seen a couple of lyrics that were kind of hard to read. P.S: I have figured it out. I had to hit enter once, and then add `#121212` |
I was wrong about CSS Overview, it's still in Chrome, it seems I read an older article. Here's the result for the first color scheme: This issue is related to the past lyrics color being There was one more issue, where "Lyrics provided by Musicmatch" color was white, but now I switched it to I also switched the lyrics hover color to You can see the changes I've made over here, in the first post. Here's the results for the second theme: It has issues with the past lyrics |
Added a couple of 4 color options, to set the desired theme, use the incoming parameter |
If you have any ideas to add new theme, then throw it here, for example: past lyrics - |
That's really nice! Thank you! :^D Just one question, what color will have the hover over the lyrics, as I'm seeing it missing from the colors attributes, will it inherit the color from current lyrics? |
right |
I was wrong, he did not inherit the color There are also lyrics without synchronization, now they inherit the color from the |
I see. If it's not too much too ask, would it be possible to make them independent of each other, meaning For example: It would be nice if I could choose another color for lyrics on hover. |
they are independent you can suggest a new profile for your theme, i will update. |
That's really nice. :^D I picked The whole theme over here: past lyrics - Thank you! You are awesome! :^D |
updated |
Hmm, it seems As an example, I used the same colors for I used Just Color Picker to get the colors: If you're using a blue filter app, please disable it, otherwise it's possible that Just Color Picker won't pick the real color. It happened in my case with CareUEyes. Could you make it possible for |
fixed attribute for past lyrics |
That's really nice! I just tested it out! P.S: |
how to apply this theme |
@GREEKY69 |
What about when playing on fullscreen? Since there's a feature that can either show the album art or the lyrics of the song. The theme works great but the fullscreen version still has colors based on the album art (I assume). |
Hello, I also wanted to add a theme if that's possible. it's basically a combination of a few of the existing themes. It would be great if you could add it. Name: past lyrics - By the way, sorry if I'm reviving an old thread. I'm very new to GitHub and I couldn't find a way to create a new thread. |
it's okay, this topic was created just for this at first glance your theme looks like "royal" or am I mistaken? |
No, you're right. It's basically the |
@amd64fox i'm wondering if you'll be adding themes for spotX, that would be a great addition! If ever that's the case, I would suggest either integrating it into the app or (which i think would be what you'd do) is add it as options for the powershell command just like the lyric themes |
Is it possible adding it? Thanks in advance |
@PetelAnavim added @amagiriyuuka |
Thanks very much |
@amd64fox Name : past lyrics - |
Co-Authored-By: vhc-vir <[email protected]> #191
added it with the name Thanks |
Thank you very much |
Hello! I've been using this app for awhile and just did a clean windows install so ended up on the FAQs of all my fav apps! I noticed the BG of spotify is close to gruvbox material so here's a lyric theme based on that. past lyrics - Also >tfw when you're trying to find what classes color the text you want edit: changed my mind about previous lyric color :p |
thanks, come up with a one word name for your theme, here is a list of existing ones |
sorry if its a dumb question, but can you tell me where do i need to type that in? |
iex "& { $(iwr -useb 'https://raw.githubusercontent.com/SpotX-Official/spotx-official.github.io/main/run.ps1') } -new_theme -lyrics_stat relish" |
Description of the new feature / enhancement
Hi there! Is there a way to accomplish this?
If indeed it is possible but it proves it would take too much work, would it be at least possible to set as default the colors of the lyrics following the color scheme from the second picture?
Thank you!
📸 Screenshots
How lyrics currently look like (on Spotify for Windows 1.1.96.785.g464c973a):
Colors displayed for the lyrics of the song: Godsmack - Bulletproof
How lyrics would look like if the following colors would be applied:
Background:
#000000
#121212
Past lyrics:
#E40909B3
<- this hex is expressed as an RGBA value, it has 8 digits (I don't know if Spotify would support that)Current lyrics:
#C2C2C2
Next lyrics:
#CA861A
"Lyrics provided by Musicmatch":
#C2C2C2
Lyrics hover:
#C2C2C2
The text was updated successfully, but these errors were encountered: