Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits are lost after user logins in #405

Closed
suhasm opened this issue Oct 5, 2022 · 4 comments
Closed

Edits are lost after user logins in #405

suhasm opened this issue Oct 5, 2022 · 4 comments

Comments

@suhasm
Copy link

suhasm commented Oct 5, 2022

To reproduce:

  1. Stay logged out, and edit a page
  2. Save changes. You will prompted to login.
  3. You login, but your edits are lost.

Suggested fix: Lock the editor unless logged in.

Our paid proofreader lost 2 pages of work due to this yesterday (I think). We may have unwittingly lost more in the past.

@akprasad
Copy link
Contributor

akprasad commented Oct 5, 2022

Currently we have this banner at the top for anonymous users:

image

But perhaps it's not clear enough, or maybe it's a case of banner blindness.

Options are:

  1. Lock the editor.
  2. Warn more aggressively once content is changed.
  3. Keep edits even after login.
  4. Allow anonymous contributions

(3) is proper but I need to research how to do it. (4) is risky without better moderation and monitoring tools. (2) could be done well, I think. (1) is the easy fix, but I also want anonymous users to be able to play around with the editor and get a sense of what it's like.

What do you think about (2)?

@suhasm
Copy link
Author

suhasm commented Oct 5, 2022

2 is fine, though I think we should also disable the save changes button. We don't want it redirecting to the login page without saving subsequently.

@akprasad
Copy link
Contributor

akprasad commented Oct 5, 2022

Sounds good -- I'll make the change.

@akprasad
Copy link
Contributor

akprasad commented Oct 7, 2022

Fixed by disabling the submit button.

@akprasad akprasad closed this as completed Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants