Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_installed missing a ! #33

Closed
benjaminschwetz opened this issue Oct 15, 2020 · 1 comment
Closed

check_installed missing a ! #33

benjaminschwetz opened this issue Oct 15, 2020 · 1 comment

Comments

@benjaminschwetz
Copy link
Contributor

Hi,

I was trying to send an htmlwidget using res$htmlwidget(), but the app kept insisting that the package is not installed. It seems like check_installed() logic is flipped, i.e. it is throwing an error when the package is installed.
@JohnCoene
Copy link
Collaborator

Indeed, Thanks; just pushed a fix.

benjaminschwetz added a commit to benjaminschwetz/ambiorix that referenced this issue Oct 15, 2020
@benjaminschwetz
Merge pull request #1 from JohnCoene/master
dc5f63b 
fix ambiorix-web#33 check_installed erroneous
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JohnCoene @benjaminschwetz