Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving stdlib as repository #330

Open
2 of 6 tasks
Mte90 opened this issue Jul 19, 2024 · 4 comments
Open
2 of 6 tasks

Moving stdlib as repository #330

Mte90 opened this issue Jul 19, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Mte90
Copy link
Member

Mte90 commented Jul 19, 2024

The needs are specific, just to move the discussions in another place, so we can focus in this repo in the compiler itself (and builtins).

The flow:

  • Wait for 0.3.5 release
  • Merge all the pending PRs for stdlib stuff
  • Create a new repo, https://github.com/amber-lang/amber-stdlib
  • move them (to define if we can move also the git history or we don't care), remove from this repository (together with tests)
  • Create in this repository the stdlib as gitmodule so we can block it to a specific commit, symlinked to the actual folders
  • Update the CI and the readme
@Mte90 Mte90 added the enhancement New feature or request label Jul 19, 2024
@Mte90 Mte90 self-assigned this Jul 19, 2024
@CymDeveloppement
Copy link
Member

@Mte90 do you think i can make a PR before moving stdlib ?
this is a PR for date function ( #325 )

@Mte90
Copy link
Member Author

Mte90 commented Jul 24, 2024

Yes just do everything now.
I am waiting the next release to move to a new repository so we have time.

Just don't forget to add the comments to the various functions.

@Mte90
Copy link
Member Author

Mte90 commented Sep 3, 2024

We have 2 folders:
immagine

That this repository need to include those 2 but the code organization is not fine for git submodules.

With a build.rs in the root that generate the simlinks we can achieve the symlink easily and in a transparent way for the user if need to compile it https://doc.rust-lang.org/cargo/reference/build-script-examples.html

@Mte90
Copy link
Member Author

Mte90 commented Sep 4, 2024

The other issue are tests but looking https://github.com/amber-lang/amber/blob/master/src/tests/stdlib.rs#L5 we don't need symlink

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants