Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 18 add children to props #249

Merged

Conversation

Maxim-Filimonov
Copy link
Contributor

React 18 removed default children props.
This adds children props to adjust typings for the library to work with react 18

@JorgenEvens JorgenEvens self-assigned this Aug 3, 2022
@JorgenEvens JorgenEvens added this to the 5.0.2 milestone Aug 3, 2022
@JorgenEvens JorgenEvens merged commit 414ffee into ambassify:master Aug 3, 2022
@JorgenEvens
Copy link
Member

Thanks for your contribution! 🎉

This has been shipped in version v5.0.2.

@Maxim-Filimonov Maxim-Filimonov deleted the react-18-fix-children-typings branch August 3, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants