Accessibility fix for default color #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorgenEvens
force-pushed
the
icon-default-colors-accessibility-fix
branch
from
5339421
to
92cac49
Compare
JorgenEvens
force-pushed
the
icon-default-colors-accessibility-fix
branch
from
92cac49
to
4747243
Compare
|
Hi @normankong , Thanks for your contribution! It has been released as part of the 5.0.0 release of react-avatar. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original default color does not have enough contrast (4.5) with white text color.
I have updated it to compatible with WCAG AA/AAA standard (4.5:1 and 7.5:1)
#d73d32 --> #A62A21
#4285f4 --> #0B51C1
#67ae3f --> #3A6024
#d61a7f --> #A81563
#ff4080 --> #B3003C
Thanks a lot !