Put Ion 1.1 support behind a feature flag #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zslayton
approved these changes
Oct 16, 2024
| @@ -1860,6 +1860,11 @@ mod tests { | |||
|
|
|||
| expect_int(context_ref, &mut reader, IonEncoding::Text_1_0, 2)?; | |||
|
|
|||
| if cfg!(not(feature = "experimental-ion-1-1")) { | |||
| @@ -125,6 +125,7 @@ pub trait RawVersionMarker<'top>: Debug + Copy + Clone + HasSpan<'top> { | |||
| fn stream_version_after_marker(&self) -> IonResult<IonVersion> { | |||
| match self.major_minor() { | |||
| (1, 0) => Ok(IonVersion::v1_0), | |||
| #[cfg(feature = "experimental-ion-1-1")] | |||
There was a problem hiding this comment.
TIL you could apply #[cfg(...)] annotations to a match arm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
I tried to make this as minimally invasive as possible:
experimental-ion-1-1feature enablesexperimental-reader-writerexperimentalfeature flag enablesexperimental-ion-1-1experimental-ion-1-1is not enabledv1_1module is onlypub(crate)(1, 1)version.Erris returned for an Ion 1.1 IVMexperimental-ion-1-1is enabled, all APIs and behaviors are as they were prior to this PRI also updated the build workflow to not cancel all outstanding jobs if one job in the build matrix fails. It's a lot quicker to identify issues if you can see that e.g. the tests pass for certain feature sets but not for others.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.