Incorporates pending feedback from lazy reader PRs #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
zslayton
changed the title
popematt
approved these changes
Sep 7, 2023
| @@ -443,7 +443,7 @@ impl MatchedString { | |||
| } | |||
| } | |||
|
|
|||
| fn decode_text_containing_escapes( | |||
| fn replace_escapes_with_byte_values( | |||
There was a problem hiding this comment.
I like this name choice. Much better than the previous one and any of my suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates feedback left on PRs:
LazyRawTextReadersupport for reading symbols #616LazyRawTextReadersupport for structs #619LazyRawTextReadersupport for reading IVMs #620Fixes issue #635.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.