Replaces map-based system symbol table with hard coded implementation #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #34
Description of changes:
I was looking at a profile for a specific application and found that interning symbols was a non-trivial portion of the profile.
When testing the change with the
ion-java-benchmark-cli, I was seeing a 5-10% improvement in writing Ion Binary for datasets with very high proportions of symbols (real world example—very wide structs). Results are inconsistent (maybe because the JVM Hotspot optimizations are not entirely deterministic or because of GC delays 🤷♂️), but have never indicated that this change makes performance worse.However, I have run into an issue where if
SharedSymbolTable. ION_1_0_SYSTEM_SYMTABuses this implementation, the test suite does not pass. It seems like the old implementations of the system symbol table are inconsistent depending on whether you get it fromSymbolsorSharedSymbolTable. After discovering that, I realized I need to step away from this for a bit in order to get other things done. I'm not sure when/if I will continue this.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.