Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test suite for Ruby 2.7.2 and JRuby #61

Merged
merged 9 commits into from
Oct 29, 2020
Merged

Conversation

HarlemSquirrel
Copy link
Member

@HarlemSquirrel HarlemSquirrel commented Oct 18, 2020

Closes actions/toolkit#58

It looks like we cannot yet allow failures in GH actions like we can in Travis. See actions/runner#2347
For now we can run our basic specs with Ruby head since it seems Active Record is broken there.

@HarlemSquirrel HarlemSquirrel changed the title Add Ruby 3.0.0-preview1 to GH CI Add Ruby head to GH CI Oct 19, 2020
@HarlemSquirrel HarlemSquirrel changed the title Add Ruby head to GH CI Update test suite for Ruby 2.7.2 and JRuby Oct 19, 2020
@HarlemSquirrel HarlemSquirrel requested a review from paddor October 29, 2020 01:56
@swiknaba
Copy link

swiknaba commented Mar 9, 2021

actually, GitHub actions does have the experimental flag, which essentially is the same as "allowed failures" from Travis: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#example-including-new-combinations

@HarlemSquirrel
Copy link
Member Author

@swiknaba that appears to be just another way to use continue-on-error but we can try it.

@swiknaba
Copy link

@swiknaba that appears to be just another way to use continue-on-error but we can try it.

Indeed, I think you're right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working tool-cache
3 participants