FIX#54 compatibility defaults with AwesomePrint #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kikonen
force-pushed
the
aprc_compatibility
branch
from
4bdfac0 to
59b5cf1
Compare
|
It's better to discard this hacky approach and simply not use ".aprc" config file in this gem, but its' own config file to avoid conflict. |
Comment on lines
+3
to
+9
| unless defined? AwesomePrint | ||
| class AwesomePrint | ||
| def self.defaults=(default_values) | ||
| AmazingPrint.defaults = default_values | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
I'm not really a fan of defining the old AwesomePrint here.
There was a problem hiding this comment.
Yes, absolutely would be better to have own config file, which does not conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #54
Compatibility logic with AwesomePrint .aprc config file