Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

due_color is not being applied when days=0 #61

Closed
danielbrunt57 opened this issue Dec 16, 2020 · 7 comments
Closed

due_color is not being applied when days=0 #61

danielbrunt57 opened this issue Dec 16, 2020 · 7 comments
Labels
bug Something isn't working

Comments

@danielbrunt57
Copy link

danielbrunt57 commented Dec 16, 2020

Describe the bug
I've just noticed that due_color is not working. The due_1_color is still being applied when number of days is 0
To Reproduce

type: vertical-stack
cards:
  - type: 'custom:garbage-collection-card'
    entity: sensor.waste
    icon_color: black
    due_color: red
    due_1_color: green
    due_txt: true
  - type: 'custom:garbage-collection-card'
    entity: sensor.recycling
    icon_color: black
    due_color: red
    due_1_color: blue
    due_txt: true

Expected behavior
I expect to see the red!

Screenshots
image

Environment (please complete the following information):

  • Garbage Collection Card version: 1.16.2
  • Browser: Firefox
  • Browser language: en-ca
  • Home Assistant Version: 2012.12.0
@danielbrunt57 danielbrunt57 added the bug Something isn't working label Dec 16, 2020
@amaximus
Copy link
Owner

Thanks for the heads-up.

Fixed in the newest release (1.16.3).
Please update the card and get back to me with results.

@danielbrunt57
Copy link
Author

Updated. No change...
image

@danielbrunt57
Copy link
Author

image

@amaximus
Copy link
Owner

Sorry, I included the wrong version into the package. Will add a new release right away.

@amaximus
Copy link
Owner

Now it should be ok.

@danielbrunt57
Copy link
Author

Perfect, thanks! So how long has that been broken and gone unnoticed??

@amaximus
Copy link
Owner

The issue has been around since the 'Clean code' commit. There is no formal testing, definitely the code review wasn't thorough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants