Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] hide_on_click stopped working after version 1.22.1 #108

Closed
Floix opened this issue Mar 13, 2023 · 8 comments
Closed

[BUG] hide_on_click stopped working after version 1.22.1 #108

Floix opened this issue Mar 13, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@Floix
Copy link

Floix commented Mar 13, 2023

Describe the bug
The hide_on_click setting is not working anymore since version 1.22.1

To Reproduce
Steps to reproduce the behavior:
Simple garbage collection setting:

 type: custom:garbage-collection-card
 entity: sensor.garbage_waste
 icon_size: 35px
 due_color: '#ff5e04'
 due_1_color: '#ff5e04'
 icon_color: '#5e5a5a'
 hide_date: false
 hide_on_click: true

hide_on_click is set to true (even though that's default), but no matter how ofter I click on due day or day before --> it won't hide anymore.

Expected behavior
Garbage card hidden.

Screenshots
Example image, click on second card, no reaction

Environment (please complete the following information):

  • Garbage Collection Card version: 1.22.3
  • Browser: chrome (110.0.5481.180) & firefox (109.0.1)
  • Browser language: German
  • Home-Assistant version 2023.3.2

Additional context

@Floix Floix added the bug Something isn't working label Mar 13, 2023
@amaximus
Copy link
Owner

Trying to reproduce the fault, the card hid on click for me.
Please make sure you are not using 'Verbose State' set to true for the garbage sensors as when it's true the sensor state is not a value between 0-2 (0: today, 1: tomorrow, 2: otherwise) but a string to display thus the card cannot decide if the due daye is today, tomorrow or otherwise.

@Floix
Copy link
Author

Floix commented Mar 14, 2023

First of all, thanks for checking. I don't think the sensor is in verbose state. This is the current state from the state check in the developer tools:

days: 0
last_collection: '2023-01-30T20:03:22.469378+01:00'
last_updated: '2023-03-14T00:00:04.573195+01:00'
next_date: '2023-03-14T00:00:00+01:00'
device_class: garbage_collection__schedule
icon: mdi:biohazard
friendly_name: Biomüll

@amaximus
Copy link
Owner

These are the attributes of the sensor, but what is the state of the sensor?

@Floix
Copy link
Author

Floix commented Mar 14, 2023

Sorry about the confusion. The state is 0 (due today).

@Floix
Copy link
Author

Floix commented Mar 14, 2023

Is there anything I could do to help you reproduce the issue or provide you with logs? Latest update 1.23.0 didn't change anything.

@amaximus
Copy link
Owner

I managed to reproduce it, I'm investigating the issue. I'll keep you posted.

@amaximus
Copy link
Owner

I just pushed a bugfix release addressing the hide_on_click issue.

Please update the card and get back to me with results.

@Floix
Copy link
Author

Floix commented Mar 15, 2023

Works again. Thank you for this fast fix!

@Floix Floix closed this as completed Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants