Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOLD import robustness #33

Open
2 tasks
edemaine opened this issue Nov 29, 2020 · 1 comment
Open
2 tasks

FOLD import robustness #33

edemaine opened this issue Nov 29, 2020 · 1 comment

Comments

@edemaine
Copy link
Collaborator

edemaine commented Nov 29, 2020

Generating FOLD files in some code of mine, I noticed the following import robustness issues:

  • If the FOLD has edges (edges_vertices and edges_assignment, and maybe certain subsets thereof, maybe even in all cases?), then it's required to also have edges_foldAngle. Should default to 180 for valleys, -180 for mountains, and 0 for others.
  • If edges_assignment has an unsupported value, then the program crashes. It should instead report an error dialog, like when there are unsupported colors in an SVG file, and default to something (U I guess?).
@hendursaga
Copy link

Not sure if this goes here, but one of the examples in the official FOLD spec does not fold properly, at least, initially.

When I first import it, it looks something like this:

box1

But when I import it a second or third time, it usually looks like this:

box2

I'm not sure what is going on. Even in the latter case, when it does fold, any change in the fold percentage and it's all haywire again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants