Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the noise_pred calculation in sds loss in dual_branch_guidance.py #27

Open
silence-tang opened this issue May 16, 2024 · 0 comments

Comments

@silence-tang
Copy link

Hi, dear authors. The code from line 541 to line 544 in dual_branch_guidance.py is here:

noise_pred_text, noise_pred_uncond = noise_pred.chunk(2) noise_pred = noise_pred_text + self.cfg.guidance_scale * (noise_pred_text - noise_pred_uncond)

I wonder if there is a small mistake. It seems that the noise_pred should be calculated by noise_pred = noise_pred_uncond + self.cfg.guidance_scale * (noise_pred_text - noise_pred_uncond)?

I don't know if I miss something important. Looking forward to hearing from you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant