Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker wrapper referenced in README is based on a fork #110

Open
typpo opened this issue Jul 30, 2019 · 3 comments
Open

Docker wrapper referenced in README is based on a fork #110

typpo opened this issue Jul 30, 2019 · 3 comments

Comments

@typpo
Copy link

typpo commented Jul 30, 2019

First, thank you all for your work on this excellent project.

The README references a docker wrapper that builds off a forked version of this repository at https://github.com/onesdk/url-to-pdf-api.

This is a bit misleading as it is 52 commits behind master, which means new fixes and features such as image rendering are not available. In the worst case, promoting a Docker image based on a fork could be a security risk.

Are you open to a PR to add a Dockerfile to this repository, or link to another Docker image that is based directly on this repository?

@kimmobrunfeldt
Copy link
Member

Good catch. I'd be willing to add a Dockerfile here.

@BobCashStory
Copy link

did a pr for this : #142

@AubreyHewes
Copy link

@BobCashStory @kimmobrunfeldt

This issue seems to be superseded/resolved by actual changes to the README.md.

The current referenced docker image is not using a fork, the referenced docker image is actually very usable and clones the master of this repo on build. How actual the image is, is up to interpretation.

I am not saying this project should not have it's own docker image, but that this issue is moot 🐄 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants