Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy for both #83

Merged
merged 57 commits into from
Jul 13, 2021
Merged

Mypy for both #83

merged 57 commits into from
Jul 13, 2021

Conversation

altendky
Copy link
Owner

@altendky altendky commented Jul 9, 2020

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #83 (7ababbc) into main (d322679) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #83   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        35           
  Lines         1971      2015   +44     
  Branches       127       138   +11     
=========================================
+ Hits          1971      2015   +44     
Impacted Files Coverage Δ
qtrio/_tests/examples/test_emissions.py 100.00% <ø> (ø)
qtrio/_core.py 100.00% <100.00%> (ø)
qtrio/_qt.py 100.00% <100.00%> (ø)
qtrio/_tests/examples/readme/test_qt.py 100.00% <100.00%> (ø)
qtrio/_tests/test_core.py 100.00% <100.00%> (ø)
qtrio/_tests/test_dialogs.py 100.00% <100.00%> (ø)
qtrio/_tests/test_qt.py 100.00% <100.00%> (ø)
qtrio/dialogs.py 100.00% <100.00%> (ø)
qtrio/examples/emissions.py 100.00% <100.00%> (ø)
qtrio/examples/readme/qt.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d322679...7ababbc. Read the comment docs.

@altendky altendky closed this Jul 9, 2020
@altendky altendky reopened this Jul 9, 2020
@altendky altendky closed this Jul 9, 2020
@altendky altendky reopened this Jul 9, 2020
@altendky altendky closed this Jul 9, 2020
@altendky altendky reopened this Jul 9, 2020
@altendky altendky marked this pull request as draft July 9, 2020 03:02
@altendky altendky mentioned this pull request Jul 9, 2020
3 tasks
@altendky altendky added the stalled Waiting on external action label Jul 11, 2020
@altendky altendky marked this pull request as ready for review July 12, 2021 19:53
@altendky altendky requested review from epcAnker and gordon-epc July 12, 2021 19:54
Copy link
Collaborator

@epcAnker epcAnker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine but gordon should have a look as well

@altendky altendky merged commit d0fddf6 into main Jul 13, 2021
@altendky altendky deleted the mypy_for_both branch July 13, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stalled Waiting on external action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixup type hinting to include qtpy
3 participants