New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async methods with @method #130

Open

thusser opened this issue Aug 15, 2022 · 1 comment

thusser commented Aug 15, 2022

Am I missing something or is it not possible to decorate async methods with @method? The wrapped method here is not marked async:
https://github.com/altdesktop/python-dbus-next/blob/master/dbus_next/service.py#L90
Should be easy to check, whether fn is a coroutine or not and then either provide an async or normal version of wrapped. Want a PR?

The text was updated successfully, but these errors were encountered:

thusser mentioned this issue

Added possibility to decorate async methods with @method #131

Open

jonasBoss commented Dec 18, 2022

It is already possible using the aio MessageBus. If you are curious why:

python-dbus-next/dbus_next/aio/message_bus.py

Line 345 in ab566e1

if not asyncio.iscoroutinefunction(method.fn):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment