Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from Vega-Lite 5.6.1 to 5.7.1 #3022

Merged
merged 5 commits into from
Apr 21, 2023
Merged

Conversation

binste
Copy link
Contributor

@binste binste commented Apr 15, 2023

I don't have a good overview if 5.7 fixes all blocking issues we had for Altair but at least on the VL GitHub repo all issues are closed.

Next up we need to again update altair_viewer so that the tests pass. @mattijn As you have done this before, do you have the cycles in the next days to do this? Totally understand if not, just let me know and I can look into it. I assume it's mainly updating and executing https://github.com/altair-viz/altair_viewer/blob/master/tools/download_scripts.py and then testing the package?

Closes #3020.

@mattijn
Copy link
Contributor

mattijn commented Apr 16, 2023

Done per altair-viz/altair_viewer#55.
Tests fail since vl-convert did not yet include vl5.7, cc @jonmmease.

@binste
Copy link
Contributor Author

binste commented Apr 16, 2023

VL Convert 0.8 should already include VL 5.7, see https://github.com/vega/vl-convert/releases/tag/v0.8.0. Just in case you @jonmmease haven't seen it, but for a few hours there was no VL 5.7 schema available as the 5.6.1 got overwritten, see vega/schema#8. Just in case this affected your update process for VLC but maybe this is not the issue.

@mattijn
Copy link
Contributor

mattijn commented Apr 16, 2023

Hm. Ok, re-reading the GitHub actions errors it seems to fail for a few examples only?

Can you locally see if all specifications fail to save through vl-convert or a selection of the examples only?

And if the latter, do we know which examples fail?

@binste
Copy link
Contributor Author

binste commented Apr 16, 2023

vl-convert 0.8 does not work for me locally, also not against our current master branch, so I opened vega/vl-convert#52. However, I don't get any errors at all so I'm not sure if it's the same issue as we are having here were we get some error messages.

@binste
Copy link
Contributor Author

binste commented Apr 16, 2023

I think we have two separate issues to deal with. There is the one I reported for vl-convert but that does not seem to be what leads to the failures in these tests. Some examples don't work with VL 5.7 such as the "Interactive Crossfilter" example which gives Unrecognized signal name: "param_2". This might be what domoritz discovered in this comment three weeks ago. Here is the VL spec that is produced by Altair.

Is this related to #2849?

@mattijn
Copy link
Contributor

mattijn commented Apr 16, 2023

Yes, I think that should be related to #2849.

@binste binste changed the title Update from Vega-Lite 5.6.1 to 5.7.0 Update from Vega-Lite 5.6.1 to 5.7.1 Apr 17, 2023
@mattijn
Copy link
Contributor

mattijn commented Apr 21, 2023

I've bumped altair_viewer to vl5.7.1 and temporarily deactivate the interactive_layered_crossfilter example to be included in the tests.
Now all tests are passing locally and within Github Actions. Merging this, so we can continue in #2849.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Vega-Lite 5.7
2 participants