Skip to content
This repository has been archived by the owner on Feb 7, 2020. It is now read-only.

exclude usage examples which don't match our author/data file #34

Closed
monzug opened this issue Sep 10, 2019 · 24 comments
Closed

exclude usage examples which don't match our author/data file #34

monzug opened this issue Sep 10, 2019 · 24 comments
Labels
bug Something isn't working verified

Comments

@monzug
Copy link

monzug commented Sep 10, 2019

Lookup for audi then go to usage word examples. the first line does not have the work and author's name, only the line number. it should be Pseudo-Varro, Sententiae + line number.
obviously it cannot be searched by author (and work).

@balmas
Copy link
Member

balmas commented Sep 10, 2019

@monzug I can't reproduce this one.

@monzug
Copy link
Author

monzug commented Sep 10, 2019

audi

@monzug
Copy link
Author

monzug commented Sep 10, 2019

tested in About Alpheios
Alpheios Embedded Library 3.0.0-beta.1.38
Alpheios Components 1.2.38

@monzug
Copy link
Author

monzug commented Sep 10, 2019

interesting not reproducible in web ext 3.0.0.64

@balmas
Copy link
Member

balmas commented Sep 10, 2019

I can't reproduce it at the texts environment either. Very strange. I am guessing it's an error from the server.

@monzug
Copy link
Author

monzug commented Sep 10, 2019 via email

@monzug
Copy link
Author

monzug commented Sep 10, 2019

IMG_3982

@monzug
Copy link
Author

monzug commented Sep 11, 2019

mobile and text env shows the 127.1 link. but I am still on Alpheios Embedded Library 3.0.0-beta.1.38
Alpheios Components 1.2.38
on desktop, Alpheios Reading Tools 3.0.0.65
Alpheios Components 1.2.39 is not reproducible

@balmas
Copy link
Member

balmas commented Sep 11, 2019

hmm. I wonder if this could be caused by a bug with the inflection tables fix for alpheios-project/components#784 that @kirlat found and fixed in components 1.2.39. There were some cases where the code was throwing an error. It shouldn't have affected the usage examples view, maybe that error interrupted the processing of the vue components.

@monzug
Copy link
Author

monzug commented Sep 11, 2019 via email

@balmas
Copy link
Member

balmas commented Sep 11, 2019

in a few minutes :-)

@monzug
Copy link
Author

monzug commented Sep 11, 2019 via email

@balmas
Copy link
Member

balmas commented Sep 11, 2019

it's there now.

@monzug
Copy link
Author

monzug commented Sep 11, 2019 via email

@balmas
Copy link
Member

balmas commented Sep 11, 2019

That is super weird. Can you do me a favor? BEFORE clicking on the usage examples button open your Chrome developer toolbar. Click on the button and then go to the Network tab of the developer toolbar.
Find the request that looks like "audio?authMax=3&max=10000000 and then click the Response tab and copy the content of the response (by right clicking on it) and save it in a text file and send it to me. (See attached screenshot which tries to show what I mean)
Screenshot from 2019-09-11 08-40-41

@monzug
Copy link
Author

monzug commented Sep 11, 2019 via email

@balmas
Copy link
Member

balmas commented Sep 11, 2019

hmmm. just seeing this for another word, veni, whose first result is 59.1 and in the data data citation is [Var].Sent.59.1 loc/1041/1/0/4453-4457

@monzug
Copy link
Author

monzug commented Sep 11, 2019 via email

@balmas
Copy link
Member

balmas commented Sep 11, 2019

Yes, we don't always get the same results for each author back from the server, that does appear to be somewhat random.

In the case I see with veni, it appears that the server is actually returning an incorrect citation. the data in the cit field is [Var].Sent.59.1 but the link actually goes to [PsVar].Sent.59.1 (Pseudo-Varro instead of Varro). Since the example with audi is also the same author I think it's probably just another example of the same data error. We aren't showing anything because we aren't finding the author and title reference in our data file, and don't know how to translate them.

The best I can do to fix this is either
(1) to show the citation abbreviation exactly as it is reported in the data (even though it's wrong)
(2) to drop the example entirely

Which do you think is better? And do you think it can wait for an incremental?

@monzug
Copy link
Author

monzug commented Sep 11, 2019 via email

@balmas
Copy link
Member

balmas commented Sep 11, 2019

agree.

@balmas balmas changed the title author and work missing in usage example for audi exclude usage examples which don't match our author/data file Sep 11, 2019
@balmas balmas transferred this issue from alpheios-project/alpheios_nemo_ui Sep 11, 2019
@balmas balmas added the bug Something isn't working label Sep 11, 2019
@balmas balmas assigned irina060981 and unassigned balmas Sep 23, 2019
@irina060981
Copy link
Member

Merged and closed

@balmas
Copy link
Member

balmas commented Sep 25, 2019

QA-3.0.1.72

@monzug
Copy link
Author

monzug commented Sep 30, 2019

pseudo-varro is gone (tested that Varro, Marcus Terentius is still in the authors list)

@monzug monzug removed their assignment Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified
Projects
None yet
Development

No branches or pull requests

3 participants