-
Notifications
You must be signed in to change notification settings - Fork 0
exclude usage examples which don't match our author/data file #34
Comments
@monzug I can't reproduce this one. |
tested in About Alpheios |
interesting not reproducible in web ext 3.0.0.64 |
I can't reproduce it at the texts environment either. Very strange. I am guessing it's an error from the server. |
oh, interesting. well, will install new build tomorrow and check again.
…On Tue, Sep 10, 2019 at 1:41 PM Bridget Almas ***@***.***> wrote:
I can't reproduce it at the texts environment either. Very strange. I am
guessing it's an error from the server.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/alpheios-project/alpheios_nemo_ui/issues/297?email_source=notifications&email_token=AJ32UOLGYCXQJFWZ5H4J55LQI7L3BA5CNFSM4IVI2IRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6L5QKA#issuecomment-530044968>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJ32UOJGN5OG2AIZ7FJOHNDQI7L3BANCNFSM4IVI2IRA>
.
|
mobile and text env shows the 127.1 link. but I am still on Alpheios Embedded Library 3.0.0-beta.1.38 |
hmm. I wonder if this could be caused by a bug with the inflection tables fix for alpheios-project/components#784 that @kirlat found and fixed in components 1.2.39. There were some cases where the code was throwing an error. It shouldn't have affected the usage examples view, maybe that error interrupted the processing of the vue components. |
looks more of data issue to me. when can I get a texts env with 1.2.39?
…On Wed, Sep 11, 2019 at 1:54 PM Bridget Almas ***@***.***> wrote:
hmm. I wonder if this could be caused by a bug with the inflection tables
fix for alpheios-project/components#784
<alpheios-project/components#784> that @kirlat
<https://github.com/kirlat> found and fixed in components 1.2.39. There
were some cases where the code was throwing an error. It shouldn't have
affected the usage examples view, maybe that error interrupted the
processing of the vue components.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/alpheios-project/alpheios_nemo_ui/issues/297?email_source=notifications&email_token=AJ32UOLEBT72KYC2RCR7RLDQJDL6ZA5CNFSM4IVI2IRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6OHFXY#issuecomment-530346719>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJ32UOOZPDFWO2FYSUOSMJ3QJDL6ZANCNFSM4IVI2IRA>
.
|
in a few minutes :-) |
in safari build
…On Wed, Sep 11, 2019 at 2:08 PM Bridget Almas ***@***.***> wrote:
in a few minutes :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/alpheios-project/alpheios_nemo_ui/issues/297?email_source=notifications&email_token=AJ32UOMDCB5KJAJQULM4NGDQJDNULA5CNFSM4IVI2IRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6OIKBA#issuecomment-530351364>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJ32UOOKUOC7FSJ5RX5RZITQJDNULANCNFSM4IVI2IRA>
.
|
it's there now. |
tested in Alpheios Components 1.2.39 - still getting the same line link for
audi (127.1)
…On Wed, Sep 11, 2019 at 8:20 AM Bridget Almas ***@***.***> wrote:
it's there now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/alpheios-project/alpheios_nemo_ui/issues/297?email_source=notifications&email_token=AJ32UOLMJCOVKF4ALGDB533QJDPCFA5CNFSM4IVI2IRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6OJH7Q#issuecomment-530355198>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJ32UOK3CR6FYVO2XDKII5DQJDPCFANCNFSM4IVI2IRA>
.
|
ok
…On Wed, Sep 11, 2019 at 2:43 PM Bridget Almas ***@***.***> wrote:
That is super weird. Can you do me a favor? BEFORE clicking on the usage
examples button open your Chrome developer toolbar. Click on the button and
then go to the Network tab of the developer toolbar.
Find the request that looks like "audio?authMax=3&max=10000000 and then
click the Response tab and copy the content of the response (by right
clicking on it) and save it in a text file and send it to me. (See attached
screenshot which tries to show what I mean)
[image: Screenshot from 2019-09-11 08-40-41]
<https://user-images.githubusercontent.com/644870/64698080-301ad000-d470-11e9-90e8-d64dce1730b1.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/alpheios-project/alpheios_nemo_ui/issues/297?email_source=notifications&email_token=AJ32UOLCRN6IWPRUXS7L3WDQJDRWRA5CNFSM4IVI2IRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6OLEDA#issuecomment-530362892>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJ32UOP2NSZKH6G4IW6QQQLQJDRWRANCNFSM4IVI2IRA>
.
|
hmmm. just seeing this for another word, veni, whose first result is 59.1 and in the data data citation is [Var].Sent.59.1 loc/1041/1/0/4453-4457 |
I see veni, 31.1 in texts env in FF - it's random generated, I guess.
…On Wed, Sep 11, 2019 at 3:08 PM Bridget Almas ***@***.***> wrote:
hmmm. just seeing this for another word, veni, whose first result is 59.1
and in the data data citation is [Var].Sent.59.1 loc/1041/1/0/4453-4457
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/alpheios-project/alpheios_nemo_ui/issues/297?email_source=notifications&email_token=AJ32UOOYLHZJZE7TMR5AJXTQJDUS7A5CNFSM4IVI2IRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6ONKMA#issuecomment-530371888>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJ32UOL7V2CSMDRYQ4M7RUDQJDUS7ANCNFSM4IVI2IRA>
.
|
Yes, we don't always get the same results for each author back from the server, that does appear to be somewhat random. In the case I see with veni, it appears that the server is actually returning an incorrect citation. the data in the cit field is [Var].Sent.59.1 but the link actually goes to [PsVar].Sent.59.1 (Pseudo-Varro instead of Varro). Since the example with audi is also the same author I think it's probably just another example of the same data error. We aren't showing anything because we aren't finding the author and title reference in our data file, and don't know how to translate them. The best I can do to fix this is either Which do you think is better? And do you think it can wait for an incremental? |
drop the example. and it can definitely wait, right?
…On Wed, Sep 11, 2019 at 3:35 PM Bridget Almas ***@***.***> wrote:
Yes, we don't always get the same results for each other back from the
server, that does appear to be somewhat random.
In the case I see with veni, it appears that the server is actually
returning an incorrect citation. the data in the cit field is
[Var].Sent.59.1 but the link actually goes to [PsVar].Sent.59.1
(Pseudo-Varro instead of Varro). Since the example with audi is also the
same author I think it's probably just another example of the same data
error. We aren't showing anything because we aren't finding the author and
title reference in our data file, and don't know how to translate them.
The best I can do to fix this is either
(1) to show the citation abbreviation exactly as it is reported in the
data (even though it's wrong)
(2) to drop the example entirely
Which do you think is better? And do you think it can wait for an
incremental?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/alpheios-project/alpheios_nemo_ui/issues/297?email_source=notifications&email_token=AJ32UOPF3O37OA4JMI5W4YDQJDX2BA5CNFSM4IVI2IRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6OQCKA#issuecomment-530383144>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJ32UONEQE2Y6LNMQGRKNSDQJDX2BANCNFSM4IVI2IRA>
.
|
agree. |
Merged and closed |
QA-3.0.1.72 |
pseudo-varro is gone (tested that Varro, Marcus Terentius is still in the authors list) |
Lookup for audi then go to usage word examples. the first line does not have the work and author's name, only the line number. it should be Pseudo-Varro, Sententiae + line number.
obviously it cannot be searched by author (and work).
The text was updated successfully, but these errors were encountered: