Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set page with anchor point in google analytics #25

Merged
merged 1 commit into from
May 18, 2018
Merged

Set page with anchor point in google analytics #25

merged 1 commit into from
May 18, 2018

Conversation

dankmitchell
Copy link

@dankmitchell dankmitchell commented May 4, 2018 •
edited
Loading

Ensure we can send the entry point to tech docs by getting the anchor tag ID from the URL

After

screen shot 2018-05-04 at 12 39 37

dan-gilbert
dan-gilbert approved these changes May 4, 2018
View reviewed changes
Copy link
Contributor

@dan-gilbert dan-gilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Change will improve Google Analytics reporting by recoridng the full page path including fragment. At the moment all page views are recorded as /

@tijmenb tijmenb merged commit ba619c7 into alphagov:master May 18, 2018
@dankmitchell dankmitchell mentioned this pull request May 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-gilbert dan-gilbert dan-gilbert approved these changes

@tijmenb tijmenb tijmenb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dankmitchell @tijmenb @dan-gilbert