Remove new_cookie_banner flag #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitabarrett
force-pushed
the
remove-new-cookie-flag
branch
from
bfe90b7 to
db588be
Compare
chao-xian
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removes
new_cookie_bannerflag on the cookie banner component.Why
Following the change to remove old cookie banner code this flag is no longer required to render the new cookie banner.
Note: this needs to be deployed only after all frontend apps have been deployed. This is so the new CSS and JS is in place before the
.gem-c-cookie-banner--newis removed from the HTML via this change.