From fd37b523d47495c5d2bd11c8f2bf26d5e17aab5c Mon Sep 17 00:00:00 2001 From: Tatiana Stantonian Date: Tue, 7 Aug 2018 14:05:59 +0100 Subject: [PATCH 1/2] Add publishing-app custom dimension This will help differentiate smart-answers from transactions. Also moved navigation-legacy to respect the ordering by custom dimension value. --- app/assets/javascripts/analytics/custom-dimensions.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/analytics/custom-dimensions.js b/app/assets/javascripts/analytics/custom-dimensions.js index b5b9ef8ff..bc38a097f 100644 --- a/app/assets/javascripts/analytics/custom-dimensions.js +++ b/app/assets/javascripts/analytics/custom-dimensions.js @@ -50,6 +50,7 @@ 'withdrawn': {dimension: 12, defaultValue: 'not withdrawn'}, 'schema-name': {dimension: 17}, 'rendering-application': {dimension: 20}, + 'navigation-legacy': {dimension: 30, defaultValue: 'none'}, 'navigation-page-type': {dimension: 32, defaultValue: 'none'}, 'user-journey-stage': {dimension: 33, defaultValue: 'thing'}, 'navigation-document-type': {dimension: 34, defaultValue: 'other'}, @@ -58,7 +59,7 @@ 'taxon-slugs': {dimension: 58, defaultValue: 'other'}, 'taxon-ids': {dimension: 59, defaultValue: 'other'}, 'content-has-history': {dimension: 39, defaultValue: 'false'}, - 'navigation-legacy': {dimension: 30, defaultValue: 'none'}, + 'publishing-app': {dimension: 89}, 'stepnavs': {dimension: 96} }; From 5211d2e9fead3a554c71864cfb3293ac88139112 Mon Sep 17 00:00:00 2001 From: Tatiana Stantonian Date: Tue, 7 Aug 2018 15:30:05 +0100 Subject: [PATCH 2/2] Bump govuk-publishing-components to 9.12 --- Gemfile | 2 +- Gemfile.lock | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Gemfile b/Gemfile index e7a739d3d..add864f08 100644 --- a/Gemfile +++ b/Gemfile @@ -10,7 +10,7 @@ gem 'sass-rails', "5.0.7" gem 'asset_bom_removal-rails', '~> 1.0.0' gem 'nokogiri', "~> 1.8" gem 'redis', "~> 4.0.1" -gem 'govuk_publishing_components', '~> 9.9.1' +gem 'govuk_publishing_components', '~> 9.12' gem 'govuk_app_config', '~> 1.8.0' group :development do diff --git a/Gemfile.lock b/Gemfile.lock index 14d8ecbd3..5fbfe20ee 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -118,7 +118,7 @@ GEM govuk_frontend_toolkit (7.6.0) railties (>= 3.1.0) sass (>= 3.2.0) - govuk_publishing_components (9.9.1) + govuk_publishing_components (9.12.0) govspeak (>= 5.0.3) govuk_app_config govuk_frontend_toolkit @@ -348,7 +348,7 @@ DEPENDENCIES govuk-lint (~> 3.8.0) govuk_app_config (~> 1.8.0) govuk_frontend_toolkit (~> 7.6.0) - govuk_publishing_components (~> 9.9.1) + govuk_publishing_components (~> 9.12) govuk_template (= 0.24.1) image_optim (= 0.26.1) jasmine-rails (~> 0.14.8)