From f499cae17b615283473340f8ad0ca8ae376798fc Mon Sep 17 00:00:00 2001 From: Elena Tanasoiu Date: Fri, 11 Aug 2017 10:43:43 +0000 Subject: [PATCH] Rename "current" to "not withdrawn" For: https://trello.com/c/KXyHx427/212-rename-current-to-not-withdrawn-when-sending-data-to-ga-on-publication-status This is aimed at clearing up some confusion in GA data where documents that are marked as current/withdrawn may actually be in a third state where they are not relevant anymore but have not yet been withdrawn. For this purpose, we're renaming the word "current" to "not withdrawn" to keep the current binary classification and reduce confusion. --- app/assets/javascripts/analytics/custom-dimensions.js | 2 +- spec/javascripts/analytics/ecommerce.spec.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/analytics/custom-dimensions.js b/app/assets/javascripts/analytics/custom-dimensions.js index d82474f2d..2b17cc9e2 100644 --- a/app/assets/javascripts/analytics/custom-dimensions.js +++ b/app/assets/javascripts/analytics/custom-dimensions.js @@ -46,7 +46,7 @@ 'political-status': {dimension: 7}, 'analytics:organisations': {dimension: 9}, 'analytics:world-locations': {dimension: 10}, - 'withdrawn': {dimension: 12, defaultValue: 'current'}, + 'withdrawn': {dimension: 12, defaultValue: 'not withdrawn'}, 'schema-name': {dimension: 17}, 'rendering-application': {dimension: 20}, 'navigation-page-type': {dimension: 32, defaultValue: 'none'}, diff --git a/spec/javascripts/analytics/ecommerce.spec.js b/spec/javascripts/analytics/ecommerce.spec.js index ffd3519b8..6fb05fa67 100644 --- a/spec/javascripts/analytics/ecommerce.spec.js +++ b/spec/javascripts/analytics/ecommerce.spec.js @@ -150,7 +150,7 @@ describe('Ecommerce reporter for results pages', function() { dimension11: '1', dimension3: 'other', dimension4: '00000000-0000-0000-0000-000000000000', - dimension12: 'current', + dimension12: 'not withdrawn', dimension23: 'unknown', dimension26: '0', dimension27: '0',