Focused, unvisited links are (extremely) low-contrast

[alex-ju]

An attempt to fix #264 raised this issue of having blue text on green buttons when focused on unvisited links.

Tested with latest Chrome, Firefox on OSX and Windows and IE9, IE10, IE11 on Windows.

If we do want to make focused links slightly darker to improve contrast, I would get rid of :link (which selects unvisited links). So the code below
a:link:focus { color: darken( $link-colour, 2.5%) }
would become
a:focus { color: darken( $link-colour, 2.5%) }
or even simpler, I would move the color attribution inside a:focus, which is a few lines above.

In this way we will have a "less powerful" selector (for improving contrast on links) that won't affect buttons.

If that sounds good, let me know and I'll come up with a PR.

[NickColley]

cc @edwardhorsford

[edwardhorsford]

The button text should always be white. It's a mistake that it's blue.

[timpaul]

Following the launch of the GOV.UK Design System, GOV.UK Template will now only get major bug fixes and security patches, so I'm going to close this.