Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logo breaks layout with increased font size #232

Closed
robinwhittleton opened this issue Jul 14, 2016 · 2 comments
Closed

Logo breaks layout with increased font size #232

robinwhittleton opened this issue Jul 14, 2016 · 2 comments
Assignees
@selfthinker

Comments

@robinwhittleton
Copy link
Contributor

robinwhittleton commented Jul 14, 2016 •
edited
Loading

WCAG2 1.4.4 says that to hit double-AA text must be able to zoom to 200% of the default size without breaking the site layout. Currently the logo is fixed to 30px which breaks the text when resized:

screen shot 2016-07-14 at 15 27 35

We should allow the header to grow in size to contain the text, probably by using min-height instead of height. Reported by @selfthinker.
@selfthinker selfthinker mentioned this issue Jul 15, 2016
Closed
@accessiblewebuk
Copy link
Member

This isn't a WCAG 2 failure in itself, because the text isn't obscured and the contrast between the white text and the blue background is still sufficient. Obviously it would be best practice for the layout not to break.

@selfthinker selfthinker mentioned this issue Aug 11, 2016
Merged
@NickColley
Copy link
Contributor

Fixed by #237 thanks @selfthinker 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@selfthinker selfthinker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@robinwhittleton @selfthinker @NickColley @accessiblewebuk