Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure of accordion and accordion docs content needs tidying up #1941

Closed
owenatgov opened this issue Feb 18, 2021 · 3 comments
Closed

Structure of accordion and accordion docs content needs tidying up #1941

owenatgov opened this issue Feb 18, 2021 · 3 comments

Comments

@owenatgov
Copy link
Contributor

This issue encompasses 2 problems uncovered in #1937

  1. There is content in the accordion js, specifically the grammatical screen reader additions for the show/hide buttons, which is isolated to that js. It could be added to a translation file and instead passed to the component in the markup, reducing the risk of the wrong language being shown to users. This is also true for the step by step component.
  2. Throughout the docs for the accordion, there are several single lines of content surrounded by quotes. This isn't necessary in YML.
@andysellick
Copy link
Contributor

The step by step component should already be getting its text from data attributes in the template, from the translation file - unless it's changed recently.

@owenatgov
Copy link
Contributor Author

The "this section" stuff isn't, that was added hastily during the run-up to WCAG-geddon last September.

@owenatgov
Copy link
Contributor Author

This has now been solved by the linked PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants