Fix auditing screens #1927
Merged
Fix auditing screens #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
fix-auditing
branch
from
2de1f8e to
85c8273
Compare
andysellick
force-pushed
the
fix-auditing
branch
from
85c8273 to
45118ed
Compare
injms
reviewed
Feb 16, 2021
andysellick
force-pushed
the
fix-auditing
branch
from
45118ed to
d246351
Compare
injms
approved these changes
Feb 18, 2021
- recent changes to the accordion had broken the accordions on the component auditing screens - this wasn't the fault of the component, the markup for the auditing accordions was hard coded - unsure why this was (even though I built it) but have replaced with the component (apparently successfully)
andysellick
force-pushed
the
fix-auditing
branch
from
d246351 to
a504f12
Compare
This was referenced Mar 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
It was broken.
Visual Changes
The only visual change is the accordion now uses the updated accordion design, but this is already known.