Update govuk-frontend base SCSS imports
#1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer the equivalent `govuk/base` imports for simplicity
|
Nice change. I'm hoping that |
|
This wes introduced in alphagov/govuk-frontend#1918 and is no longer needed since govuk-frontend 3.9.0
alex-ju
force-pushed
the
govuk-frontend-imports
branch
from
d6b74fd to
9b053ac
Compare
alex-ju
added a commit
that referenced
this pull request
Feb 15, 2021
## 24.1.1 * Fix deprecation warnings when running tests ([PR #1899](#1899)) * Update `govuk-frontend` base SCSS imports ([PR #1922](#1922)) * Remove redundant import in accordion component ([PR #1923](#1923)) * Fix toggle click tracking on step-by-steps ([PR #1925](#1925)) * Accordion summary design adjustment ([PR #1926](#1926)) * Fix `layout_header` layout and spacing issues ([PR #1924](#1924))
Merged
This was referenced Mar 11, 2021
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Clean up
govuk_frontend_support.scssWhy
It's recommended to import base instead of settings, tools, helpers since
govuk-frontend3.7.0The FCDO colour is already available since
govuk-frontend3.9.0Note
In
govuk-frontend4.0.0 we won't be able to importcoreandoverrideswithoutbase, which means that ourcomponent_support.scssmust importgovuk_frontend_support.scssby default instead of doing it separately/optionally at the app level.Visual Changes
No visual changes