-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update data-module on layout header and footer #1913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have this in lib
and planning to remove it from static very soon https://github.com/alphagov/govuk_publishing_components/blob/master/app/assets/javascripts/govuk_publishing_components/lib/track-click.js
Change value of data-module attribute to "gem-track-click" on the layout header and layout footer components. The reason behind this change is that click tracking is not working on these elements on GOVUK Accounts. This is because Accounts does not use static and therefore also does not use the track-click script which enables click tracking on modules with the data-module="track-click" attribute. Changing the value of this attribute to "gem-track-click" means that the header and footer will work with the gem's track-click script instead.
Yeah you're right @alex-ju. |
a4e352d
to
7f5d086
Compare
Thanks for looking into this, @danacotoran! That's great news! This is how we actually ended up with the current version in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to add a changelog entry.
We'll have to do this for every component, unfortunately, before being able to remove the copy in static
.
What
Change value of
data-module
attribute to "gem-track-click" on the layout header and layout footer components.Why
The reason behind this change is that click tracking is not working on these elements on GOVUK Accounts.
That is because Accounts does not use
static
and therefore also does not use the track-click script which enables click tracking on modules with thedata-module="track-click"
attribute.Changing the value of this attribute to "gem-track-click" means that the header and footer will work with the component gem's track-click script instead.
https://trello.com/c/9A6UPqi8